unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Issues running gitmerge
Date: Tue, 22 Aug 2023 09:03:17 +0800	[thread overview]
Message-ID: <87sf8banxm.fsf@yahoo.com> (raw)
In-Reply-To: <cbef3b60-f652-a9ba-bb0a-a04278464605@gmail.com> (Jim Porter's message of "Mon, 21 Aug 2023 17:37:57 -0700")

Jim Porter <jporterbugs@gmail.com> writes:

> I noticed that it's been about a week since we last ran gitmerge, and
> so I attempted it since I have a couple of changes to the Eshell
> manual on the release branch that I want to merge into
> master. However, running gitmerge fails, I think due to our pre-commit
> hook complaining. The failing files are:
>
>   ChangeLog.android
>     The hook rejects files with ChangeLog in the name, but reports the
>     wrong error due to a (probable) bug in the hook.

ChangeLog.android should be kept.  The hook should be fixed.

>   java/INSTALL
>     Whitespace "issues" (which are probably non-issues since these are
>     part of in-line diffs).
>
>   java/README
>     Extraneous newline at the end.

The hook must be taught to ignore these files.

>   java/res/drawable/emacs_background.xml:30
>     Trailing whitespace (probably a real issue)
>
> The last two are easy enough to fix, but I'm not sure what to do about
> the others. Can we tell Git to ignore these problems? Should we fix
> them somehow? I'm no expert on the gitmerge process, so maybe I'm just
> missing something obvious.

I asked this question a week ago, but none of the Git experts who
frequent this list replied.

I will fix emacs_background.xml.



  reply	other threads:[~2023-08-22  1:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22  0:37 Issues running gitmerge Jim Porter
2023-08-22  1:03 ` Po Lu [this message]
2023-08-22  1:28   ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf8banxm.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).