From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dired-duplicates Date: Wed, 01 Nov 2023 03:14:42 +0100 Message-ID: <87sf5qusml.fsf@web.de> References: <875y2nugm8.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1576"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:N3uueH7CWSZ+BT6wfiTXOJuWDc8= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 01 03:15:44 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qy0la-000AHj-Ld for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Nov 2023 03:15:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qy0ks-0004cD-Ur; Tue, 31 Oct 2023 22:14:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qy0ko-0004by-Fl for emacs-devel@gnu.org; Tue, 31 Oct 2023 22:14:46 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qy0kl-0005b3-8J for emacs-devel@gnu.org; Tue, 31 Oct 2023 22:14:46 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qy0kg-0008qt-QR for emacs-devel@gnu.org; Wed, 01 Nov 2023 03:14:38 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312036 Archived-At: Harald Judt writes: > > diff --git a/dired-duplicates.el b/dired-duplicates.el > > index d62af02..4af37a3 100644 > > --- a/dired-duplicates.el > > +++ b/dired-duplicates.el > > @@ -54,7 +54,6 @@ > > (defcustom dired-duplicates-separate-results > > t > > "Boolean value indicating whether to separate results with new-lines." > > - :group 'dired-duplicates > > [...] > > Why should I not use :group for customization? I thought this makes it > easier to explore customization? It's redundant - see (info "(elisp) Variable Definitions"): If a ‘defcustom’ does not specify any ‘:group’, the last group defined with ‘defgroup’ in the same file will be used. This way, most ‘defcustom’ do not need an explicit ‘:group’. If :group is specified, it will most of the time mean the defcustom should be assigned to some other, not to the default, group. So it's better style to not explicitly specify the default. Michael.