From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make ispell localwords safe local variable Date: Fri, 01 Dec 2023 00:24:49 -0800 Message-ID: <87sf4muy5o.fsf@breatheoutbreathe.in> References: <87zg2s97x0.fsf@breatheoutbreathe.in> <83o7j8a59k.fsf@gnu.org> <87h6ozdalc.fsf@breatheoutbreathe.in> <83jztv89gi.fsf@gnu.org> <83wmxikyuk.fsf@gnu.org> <87wmtyv21h.fsf@breatheoutbreathe.in> <831qc6bb9j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39467"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 01 12:26:09 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r91eq-0009te-6j for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Dec 2023 12:26:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r91ds-0001aW-33; Fri, 01 Dec 2023 06:25:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8yqi-0007WC-21 for emacs-devel@gnu.org; Fri, 01 Dec 2023 03:26:12 -0500 Original-Received: from out-177.mta1.migadu.com ([95.215.58.177]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8yqc-0004bl-By for emacs-devel@gnu.org; Fri, 01 Dec 2023 03:26:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1701419160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kKmotBfaVO5oUOO+kVKpzobtnTzwYdgQSsNazsNQMqk=; b=PV+V1Fkl9R/l1hD6zrZuhfw7uQcKXH6Z+igbYZGJNMsj4LtBrxgAucsu69WzfieNyJffYI j1mxT+1WKkTvao/LLzhaUpE19891IQr0KoD1G2Si5S+E+kvy+920AfYr8olT8xq71k8QmW jVBfwhQHTDn8oNQ+Rha/O/R2A0H6OQs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <831qc6bb9j.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.177; envelope-from=joseph@breatheoutbreathe.in; helo=out-177.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 01 Dec 2023 06:25:05 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313433 Archived-At: Eli Zaretskii writes: >> From: Joseph Turner >> Cc: jporterbugs@gmail.com, emacs-devel@gnu.org >> Date: Thu, 30 Nov 2023 22:56:45 -0800 >> >> Eli Zaretskii writes: >> >> > It sounds like no one sees a problem with this change, so I've now >> > installed it on the master branch. >> >> Would you be willing to merge the same commit on the emacs-29 branch? > > Sorry, no. There were some questions about this being safe that I > think only time can answer in a satisfactory manner. Leaving this on > master will give users enough time to try this and provide feedback in > case we overlooked something, before we release that code. > >> If ispell-buffer-session-localwords is not safe, then package-vc-install >> fails to install packages which set it in a dir-locals.el. This is >> currently the case with hyperdrive.el, whose manual recommends that >> users mark it as safe in their own configuration prior to installation. > > Users who are hit by this problem can indeed add the necessary form in > their init files. Or they can use the development version from the > master branch. Or install the change locally and rebuild Emacs 29. > I'm sorry, but declaring a variable safe is a serious business in > Emacs, and we cannot do that in the middle of releasing a version of > Emacs which was used and tested without such a declaration. Thank you for your thorough explanation and your caution!! I'm grateful to have you as Emacs co-maintainer. Joseph