Re: Permanently fix org versioning breakage during builds?

[Ihor Radchenko <yantar92@posteo.net>]

Eli Zaretskii <eliz@gnu.org> writes:

>> The main problem is that with org-assert-version, "from time to time"
>> becomes more frequent as the breakage is guaranteed every time a new
>> version of Org is installed into Emacs tree.
>
> If org-assert-version is the source of breakage, then that's not the
> breakage I was talking about.  I was talking about breakage due to
> changes in macros that were the motivation for you to introduce
> org-assert-version in the first place.
>
> IOW, instead of _inducing_ a breakage via org-assert-version, you
> should let stuff break by itself, when an incompatible change is made
> in one of the macros which org-assert-version protects.

Yep. That's what I've done now. `org-assert-version' now throws a
warning instead of error:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=af1821673

The remaining problem (maybe) is that even the warning may not be
desired:

(from Po Lu's messages)
>>> Thanks, but ideally Emacs should not display warnings loading
>>> built-in files

And I am still interested to discuss further on the alternative ways to
address the problem with macros _and also_ the problem with multiple Org
versions being loaded.

For macros, João Távora suggested wrapping them into a function call and
then use the function call + (lambda () ...) instead of macros.
Although I am not sure how it will affect byte- and native-compilation.
And it feels like very awkward workaround that should not be necessary.

For mixed versions, no suggestions were surfaced yet in this discussion.
(Although, I am still trying to make previous ideas with
require-with-shadowcheck work in a local WIP feature branch).

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>