* Re: scratch/igc 956097054f2 1/3: Fix scroll bars for GTK
[not found] ` <20240505075752.7F6BAC2BC91@vcs2.savannah.gnu.org>
@ 2024-05-05 8:25 ` Po Lu
2024-05-05 8:47 ` Helmut Eller
0 siblings, 1 reply; 3+ messages in thread
From: Po Lu @ 2024-05-05 8:25 UTC (permalink / raw)
To: emacs-devel; +Cc: Helmut Eller
Gerd Moellmann <gerd@gnu.org> writes:
> +#ifdef HAVE_MPS
> + // FIXME: can use exact reference
> + struct scroll_bar **bar_cell =
> + igc_xzalloc_ambig (sizeof (struct scroll_bar*));
> + bar_cell[0] = bar;
[...]
> #ifdef HAVE_MPS
> + // FIXME: use exact references
> dpyinfo->devices = igc_xzalloc_ambig (sizeof *dpyinfo->devices * ndevices);
[...]
> #ifdef HAVE_MPS
> + // FIXME: use exact references
> devices = igc_xzalloc_ambig (sizeof *devices * dpyinfo->num_devices);
[...]
> +#ifdef HAVE_MPS
> + struct scroll_bar** bar_cell = user_data;
> + bar = *bar_cell;
[...]
> #ifdef HAVE_MPS
> + // FIXME: use exact references
> dpyinfo = igc_xzalloc_ambig (sizeof *dpyinfo);
Helmut, I understand that this is a scratch branch where standards are
significantly relaxed, but observing our coding conventions now will
relieve us of plenty of needless toil when the time comes to merge it.
Please avoid C++-style comments, break the assignment operator rather
than its RHS, place asterisks against identifiers, not the types which
they modify, and maintain lines within the 80 column limit as best you
can.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: scratch/igc 956097054f2 1/3: Fix scroll bars for GTK
2024-05-05 8:25 ` scratch/igc 956097054f2 1/3: Fix scroll bars for GTK Po Lu
@ 2024-05-05 8:47 ` Helmut Eller
2024-05-05 9:09 ` Po Lu
0 siblings, 1 reply; 3+ messages in thread
From: Helmut Eller @ 2024-05-05 8:47 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
On Sun, May 05 2024, Po Lu wrote:
> Helmut, I understand that this is a scratch branch where standards are
> significantly relaxed, but observing our coding conventions now will
> relieve us of plenty of needless toil when the time comes to merge it.
> Please avoid C++-style comments,
I thought C99 is allowed. It would be easier if compiler switches were
configured so that one hasn't to remember all those rules.
> break the assignment operator rather
> than its RHS, place asterisks against identifiers, not the types which
> they modify, and maintain lines within the 80 column limit as best you
> can.
Is there a tool like clang-format, that I could put in the
before-save-hook that get the formatting and line breaks right?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-05 9:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171489587140.23584.9676404455599459034@vcs2.savannah.gnu.org>
[not found] ` <20240505075752.7F6BAC2BC91@vcs2.savannah.gnu.org>
2024-05-05 8:25 ` scratch/igc 956097054f2 1/3: Fix scroll bars for GTK Po Lu
2024-05-05 8:47 ` Helmut Eller
2024-05-05 9:09 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).