From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Start of Emacs 30 release cycle Date: Tue, 25 Jun 2024 16:10:30 +0200 Message-ID: <87sex19kq1.fsf@gmail.com> References: <86frt3eptb.fsf@gnu.org> <8734p2212i.fsf@gmx.net> <86jziebj8j.fsf@gnu.org> <87pls6zc0r.fsf@rub.de> <86cyo6bcub.fsf@gnu.org> <87y16t485d.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22183"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , maurooaranda@gmail.com, emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 25 16:11:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sM6tI-0005YF-7x for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jun 2024 16:11:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sM6se-0006uZ-RS; Tue, 25 Jun 2024 10:10:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sM6sa-0006tR-5X for emacs-devel@gnu.org; Tue, 25 Jun 2024 10:10:41 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sM6sX-0002aI-LR; Tue, 25 Jun 2024 10:10:39 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-362f62ae4c5so3226750f8f.1; Tue, 25 Jun 2024 07:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719324632; x=1719929432; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=KJ0mHcUA/Jd/wf9pRdXP1MSyoK9r8QHXU15sOcoLg0o=; b=AEFgfpbyCWIwZLdijQBYumVZGd9GUbkF45qRH+LdeVG3Tglmw5JSsIL9dhOM1xH9LC cUNjSeDA+tcTPGm19C+XQRVkFbvaT0bsEPoY5Mq/VpzQaFMVCYPWUE41jRM4gtHYgSPt /Hls5R2wSi027616fmQfVRr+Wadr24QZCcF6c6DNUCDnZ1GHnua3jdvvCMERqLGMM3MT gfj4tczcL/D2BYp2L2ypd1qfIkEiz1+HjmefavdHSvXDQCiOXM/AY2suQWEl1AH7QxEW hrrg3scu4w1l76v6oU9nWITpFD/EWE1DuwK5qlSLIPwrMfWrQZB/8VnnGEuOXVchg738 67zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719324632; x=1719929432; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KJ0mHcUA/Jd/wf9pRdXP1MSyoK9r8QHXU15sOcoLg0o=; b=Evr8blCD/pYgu6LSuIEyNByLOvOfIAbI3cO/mSmOh13IIv2K0alG7jmz+YVMzjeiEh 2efyDGKH+uNBljHXM0jziht4yWloZfpbp4ducor/T8ASqS8Ijxk4rbRCctj/dEI0m7W9 Uv24XtRuymqMVP1hSOBjbdzvTc52q9pjKpVoqf34QO8C1qxahz2Tv+d5Rch/S/ri3OSp eUFm10VNllYnBX+Y6h02ZfIdDprrezlbKyO5lr8MYOpkgBj44tOtKCeXbDF6gcPmd4MS NUI5ku8Xq0DcBnJl1rblJCfPOouQ905unH1MWP8sSuKe4ZRN4td3vNt5FG7Q8yvlsll/ ztAQ== X-Forwarded-Encrypted: i=1; AJvYcCX0pBVZqa3K8o67eGDLzg3CcOjkxMSCMETEnr4TG+7QZaNCCVdAkQid4ci06B7va5jEH3mOv4ZWH6QHKncTJq97IToN X-Gm-Message-State: AOJu0YwMUlxkyrcaFei9oEUCNtH/2NRHVrh3ewKPJeYeSMdmHcoE6d/1 x1VdmMyNHSYJXWQoNYsJ5ZM73M6+qr15XxN7fSk40Kx/XxmKuAI+3S3KWQ== X-Google-Smtp-Source: AGHT+IFesPgQMwpymKiFki5CJRk9Q23mJa1/0ZHhdb4O3UHe18o+EenZipWyfSUqbnJtc9Jb/dfOuQ== X-Received: by 2002:adf:f990:0:b0:361:e909:60c3 with SMTP id ffacd0b85a97d-366e3267fb9mr6930301f8f.9.1719324631790; Tue, 25 Jun 2024 07:10:31 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36647e7eb4fsm13061419f8f.18.2024.06.25.07.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 07:10:31 -0700 (PDT) In-Reply-To: <87y16t485d.fsf@gmx.net> (Stephen Berman's message of "Tue, 25 Jun 2024 12:41:02 +0200") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=rpluim@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320634 Archived-At: >>>>> On Tue, 25 Jun 2024 12:41:02 +0200, Stephen Berman said: Stephen> Yes, indeed. Is the attached complete patch ready to install = in Stephen> emacs-30? Minor comments below (although globally I=CA=BCd say you=CA=BCre overriding= the .dir-locals.el setting for `indent-tabs-mode', which is why the diffs look funny) Stephen> diff --git a/doc/misc/widget.texi b/doc/misc/widget.texi Stephen> index 2e378e86fc7..8769d9c6191 100644 Stephen> --- a/doc/misc/widget.texi Stephen> +++ b/doc/misc/widget.texi Stephen> @@ -3287,6 +3287,16 @@ Customization Stephen> Face used for inactive widgets. Stephen> @end deffn Stephen> +@deffn Face widget-unselected Stephen> +Face used for unselected widgets. This face is also used on = the text Stephen> +labels of radio-button and checkbox widgets. Stephen> + Stephen> +The default value inherits @code{widget-inactive} face. If y= ou want to 'inherits from the' Stephen> +visually distinguish the labels of unselected active radio-bu= tton or Stephen> +checkbox widgets from the labels of unselected inactive widge= ts, Stephen> +customize this face to a non-default value. Stephen> +@end deffn Stephen> + Stephen> @defopt widget-mouse-face Stephen> Face used for highlighting a button when the mouse pointer mo= ves Stephen> across it. Stephen> diff --git a/etc/NEWS b/etc/NEWS Stephen> index d8fa92eb71e..841eb7c9c35 100644 Stephen> --- a/etc/NEWS Stephen> +++ b/etc/NEWS Stephen> @@ -1906,6 +1906,12 @@ options of GNU 'ls'. Stephen> ** Widget Stephen> +++ Stephen> +*** New face 'widget-unselected'. Stephen> +Customize this face to a non-default value to visually distin= guish the Stephen> +labels of unselected active radio-button or checkbox widgets = from the Stephen> +labels of unselected inactive widgets (the default value inhe= rits 'inherits from the' Stephen> +'widget-inactive' face). Stephen> + Stephen> *** New user option 'widget-skip-inactive'. Stephen> If non-nil, moving point forward or backward between widgets = by typing Stephen> 'TAB' or 'S-TAB' skips over inactive widgets. The default va= lue is nil. Stephen> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el Stephen> index 3b467434d29..c86e82f5852 100644 Stephen> --- a/lisp/wid-edit.el Stephen> +++ b/lisp/wid-edit.el Stephen> @@ -568,6 +568,29 @@ widget-specify-active Stephen> (delete-overlay inactive) Stephen> (widget-put widget :inactive nil)))) Stephen> +(defface widget-unselected Stephen> + '((t :inherit widget-inactive)) Stephen> + "Face used for unselected widgets." Stephen> + :group 'widget-faces Stephen> + :version "30.1") Stephen> + Stephen> +(defun widget-specify-unselected (widget from to) Stephen> + "Fontify WIDGET as unselected (not chosen)." I think the "(not chosen)" bit is redundant. Stephen> + (let ((overlay (make-overlay from to nil t nil))) Stephen> + (overlay-put overlay 'face 'widget-unselected) Stephen> + (overlay-put overlay 'evaporate t) Stephen> + ;; The overlay priority here should be lower than the pri= ority in Stephen> + ;; `widget-specify-active' (bug#69942). Stephen> + (overlay-put overlay 'priority 90) Stephen> + (widget-put widget :unselected overlay))) Stephen> + Stephen> +(defun widget-specify-selected (widget) Stephen> + "Remove fontification of WIDGET as unselected (not chosen)." And here as well. Robert --=20