Re: Start of Emacs 30 release cycle

[Stephen Berman <stephen.berman@gmx.net>]

On Tue, 25 Jun 2024 18:57:33 +0300 Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  maurooaranda@gmail.com,  emacs-devel@gnu.org
>> Date: Tue, 25 Jun 2024 17:09:48 +0200
>> 
>>     Stephen> I haven't changed indent-tabs-mode: its global value is the default t
>>     Stephen> but in buffers under emacs/lisp nil.  And the diffs don't look
>>     Stephen> funny to
>>     Stephen> me; how do they look funny to you?
>> 
>> eg this hunk:
>> 
>>  (defsubst widget-type (widget)
>> @@ -2452,10 +2475,16 @@ 'checkbox
>>  (defun widget-checkbox-action (widget &optional event)
>>    "Toggle checkbox, notify parent, and set active state of sibling."
>>    (widget-toggle-action widget event)
>> -  (let ((sibling (widget-get-sibling widget)))
>> +  (let* ((sibling (widget-get-sibling widget))
>> +         (from (widget-get sibling :from))
>> +	 (to (widget-get sibling :to)))
>> 
>> Thereʼs a tab on the line for 'to', but the line for 'from' uses spaces.

Ah, right.  I see things like that when I give the diff a close look,
but since the faces of whitespace-mode, though enabled, are not visible
in diff-mode (is this intended?), I often don't notice it.

> The original .dir-locals.el also has TABs.

And wid-edit.el is replete with tabs and spaces, so if I unintentionally
added a tab or two (but using only default settings for
emacs-lisp-mode), I don't think it significantly worsens the situation.

Steve Berman