Re: master a20f4c7ce19 1/2: Fix string used in recent obsolete variables spec

Re: master a20f4c7ce19 1/2: Fix string used in recent obsolete variables spec

[Stefan Kangas]

Michael Albinus via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

>  (make-obsolete-variable
>   'font-lock-comment-face
> - "use the quoted symbol instead: \\='font-lock-comment-face" "31.1")
> + "use the quoted symbol instead: 'font-lock-comment-face" "31.1")

With this change, the warning reads:

    use the quoted symbol instead: ’font-lock-warning-face

The idea is that it should be valid Lisp, so that users can copy and use
it directly.  In other words, it should use a regular ' character:

    use the quoted symbol instead: 'font-lock-warning-face

I suggest reverting this patch.  Thanks.

Re: master a20f4c7ce19 1/2: Fix string used in recent obsolete variables spec

[Michael Albinus]

Stefan Kangas <stefankangas@gmail.com> writes:

Hi Stefan,

> Michael Albinus via Mailing list for Emacs changes <emacs-diffs@gnu.org>
> writes:
>
>>  (make-obsolete-variable
>>   'font-lock-comment-face
>> - "use the quoted symbol instead: \\='font-lock-comment-face" "31.1")
>> + "use the quoted symbol instead: 'font-lock-comment-face" "31.1")
>
> With this change, the warning reads:
>
>     use the quoted symbol instead: ’font-lock-warning-face

When I use emacs -Q, it reads correctly in the *Help* buffer (calling describe-variable)

--8<---------------cut here---------------start------------->8---
    use the quoted symbol instead: 'font-lock-warning-face
--8<---------------cut here---------------end--------------->8---

> The idea is that it should be valid Lisp, so that users can copy and use
> it directly.  In other words, it should use a regular ' character:
>
>     use the quoted symbol instead: 'font-lock-warning-face
>
> I suggest reverting this patch.  Thanks.

But then, I see in the *Help* buffer

--8<---------------cut here---------------start------------->8---
    use the quoted symbol instead: \='font-lock-warning-face
--8<---------------cut here---------------end--------------->8---

So we must modify help-fns--var-obsolete to use
substitute-command-keys. I've changed it, and I've reverted my
patch. That should be OK then.

Best regards, Michael.

Re: master a20f4c7ce19 1/2: Fix string used in recent obsolete variables spec

[Stefan Kangas]

Michael Albinus <Michael.Albinus@gmx.de> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
> But then, I see in the *Help* buffer
>
> --8<---------------cut here---------------start------------->8---
>     use the quoted symbol instead: \='font-lock-warning-face
> --8<---------------cut here---------------end--------------->8---
>
> So we must modify help-fns--var-obsolete to use
> substitute-command-keys. I've changed it, and I've reverted my
> patch. That should be OK then.

Ah, nice catch.  Thank you!