From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: mh-e/mh-acros.el advices `require' incorrectly Date: Sat, 14 Jan 2006 12:47:37 -0500 Message-ID: <87r77au2gl.fsf-monnier+emacs@gnu.org> References: <87hd87g62x.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1137266330 20968 80.91.229.2 (14 Jan 2006 19:18:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 14 Jan 2006 19:18:50 +0000 (UTC) Cc: emacs-devel@gnu.org, handa@m17n.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 14 20:18:46 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Exqv3-0006PW-4q for ged-emacs-devel@m.gmane.org; Sat, 14 Jan 2006 20:18:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ExqtE-0003GG-R5 for ged-emacs-devel@m.gmane.org; Sat, 14 Jan 2006 14:16:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ExpXO-00059U-2R for emacs-devel@gnu.org; Sat, 14 Jan 2006 12:50:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ExpXL-00058N-JI for emacs-devel@gnu.org; Sat, 14 Jan 2006 12:50:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ExpXK-00057s-6c for emacs-devel@gnu.org; Sat, 14 Jan 2006 12:49:58 -0500 Original-Received: from [209.226.175.54] (helo=tomts10-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ExpaU-0003KU-8T; Sat, 14 Jan 2006 12:53:14 -0500 Original-Received: from alfajor ([67.71.26.73]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060114174737.MTVE14963.tomts10-srv.bellnexxia.net@alfajor>; Sat, 14 Jan 2006 12:47:37 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 495E1D736A; Sat, 14 Jan 2006 12:47:37 -0500 (EST) Original-To: rms@gnu.org In-Reply-To: (Richard M. Stallman's message of "Sat, 14 Jan 2006 11:14:27 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49092 Archived-At: > --- orig/lisp/emacs-lisp/bytecomp.el > +++ mod/lisp/emacs-lisp/bytecomp.el > @@ -1640,6 +1640,12 @@ > ;; Force logging of the file name for each file compiled. > (setq byte-compile-last-logged-file nil) > (let ((byte-compile-current-file filename) > + ;; Prefer source files over compiled files. This is so that when > + ;; several files are changed and recompiled, each new file is > + ;; properly recompiled with the new macros in the other new files. > + (load-suffixes (sort (copy-sequence load-suffixes) > + (lambda (s1 s2) (and (string-match "\\.elc\\b" s2) > + (string-match "\\.el\\b" s1))))) > (set-auto-coding-for-load t) > target-file input-buffer output-buffer > byte-compile-dest-file) > That creates an inconsistency. If it were a reliable solution to the > problem, that could justify the inconsistency. But it isn't reliable, > because if the file require'd was already loaded in bytecode outside > the compiler, this won't reload it. Indeed, it's just a minor convenience hack. > For the same reason, the advice in mh-e.el is not a good solution > (even disregarding that it is a bad thing for parts of Emacs to > advise other parts). 100% agreement. Stefan