From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: static declaration inside `window_scroll_pixel_based' in window.c Date: Wed, 08 Mar 2006 21:04:11 -0500 Message-ID: <87r75c5q78.fsf@stupidchicken.com> References: <200603090049.k290nQK23320@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1141869875 3615 80.91.229.2 (9 Mar 2006 02:04:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 9 Mar 2006 02:04:35 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 09 03:04:34 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FHAVu-0004d3-Fs for ged-emacs-devel@m.gmane.org; Thu, 09 Mar 2006 03:04:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FHAVt-0004hZ-Uw for ged-emacs-devel@m.gmane.org; Wed, 08 Mar 2006 21:04:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FHAVg-0004Z4-VF for emacs-devel@gnu.org; Wed, 08 Mar 2006 21:04:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FHAVf-0004Lr-3T for emacs-devel@gnu.org; Wed, 08 Mar 2006 21:04:12 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FHAVf-0004Kh-09 for emacs-devel@gnu.org; Wed, 08 Mar 2006 21:04:11 -0500 Original-Received: from [18.95.6.38] (helo=outgoing.mit.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FHAYc-0005Tl-Q2 for emacs-devel@gnu.org; Wed, 08 Mar 2006 21:07:14 -0500 Original-Received: by outgoing.mit.edu (Postfix, from userid 1000) id 71C6E1E4142; Wed, 8 Mar 2006 21:04:11 -0500 (EST) Original-To: Luc Teirlinck In-Reply-To: <200603090049.k290nQK23320@raven.dms.auburn.edu> (Luc Teirlinck's message of "Wed, 8 Mar 2006 18:49:26 -0600 (CST)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51392 Archived-At: Luc Teirlinck writes: >>>From my earlier message: > > Anyway, if the above quote from `(elisp)Writing Emacs Primitives' does > apply here, the problem would be easy to fix with the following patch, > which I can install if desired. > > No, I responded too quickly. The patch is incorrect, since it always > re-initializes preserve_y to -1 at the start of `window_scroll_pixel_based', > defeating its static-ness. You can simply initialize it in syms_of_window.