From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ryan Yeske Newsgroups: gmane.emacs.devel Subject: Re: rcirc bug Date: Thu, 07 Sep 2006 16:19:42 -0700 Message-ID: <87r6yns1rl.fsf@cut.bc.hsia.telus.net> References: <20060904135111.7ADB544005@Psilocybe.Update.UU.SE> <87mz9eknqm.fsf@cut.bc.hsia.telus.net> <20060905213720.A150744004@Psilocybe.Update.UU.SE> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1157671207 19770 80.91.229.2 (7 Sep 2006 23:20:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 7 Sep 2006 23:20:07 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 08 01:20:07 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GLTAC-0005t1-NA for ged-emacs-devel@m.gmane.org; Fri, 08 Sep 2006 01:20:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GLTAC-0001Nu-0q for ged-emacs-devel@m.gmane.org; Thu, 07 Sep 2006 19:20:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GLT9x-0001JP-Vo for emacs-devel@gnu.org; Thu, 07 Sep 2006 19:19:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GLT9v-0001EG-41 for emacs-devel@gnu.org; Thu, 07 Sep 2006 19:19:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GLT9u-0001DQ-LO for emacs-devel@gnu.org; Thu, 07 Sep 2006 19:19:46 -0400 Original-Received: from [204.209.205.55] (helo=defout.telus.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GLTAM-0003ow-Te; Thu, 07 Sep 2006 19:20:15 -0400 Original-Received: from priv-edmwaa06.telusplanet.net ([207.6.239.189]) by priv-edmwes50.telusplanet.net (InterMail vM.7.05.01.01 201-2174-106-103-20060222) with ESMTP id <20060907231943.EYMP17469.priv-edmwes50.telusplanet.net@priv-edmwaa06.telusplanet.net>; Thu, 7 Sep 2006 17:19:43 -0600 Original-Received: from cut.bc.hsia.telus.net (d207-6-239-189.bchsia.telus.net [207.6.239.189]) by priv-edmwaa06.telusplanet.net (BorderWare MXtreme Infinity Mail Firewall) with ESMTP id F63CL09LH5; Thu, 7 Sep 2006 17:19:42 -0600 (MDT) Original-To: ams@gnu.org In-reply-to: <20060905213720.A150744004@Psilocybe.Update.UU.SE> (ams@gnu.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59533 Archived-At: From: "Alfred M. Szmidt" CC: emacs-devel@gnu.org Reply-to: ams@gnu.org Date: Tue, 5 Sep 2006 23:37:20 +0200 (CEST) > rcirc tries to use member* without (require 'cl), which causes > breakage. The following patch fixes this: I don't think it will fix the problem in full; pushnew is also a 'cl macro. Maybe just changing pushnew to add-to-list would work? I don't know if there are more 'cl-isms in rcirc... That is true, case seems to be fine, pushnew is the culprit, as it the function cl-adjoin is called, which includes member*. I believe this is the correct fix: *** rcirc.el 05 Sep 2006 12:14:49 -0700 1.26 --- rcirc.el 07 Sep 2006 15:56:32 -0700 *************** *** 1495,1501 **** (let ((t1 (with-current-buffer b1 rcirc-last-post-time)) (t2 (with-current-buffer b2 rcirc-last-post-time))) (time-less-p t2 t1))))) ! (pushnew type rcirc-activity-types) (rcirc-update-activity-string))) (run-hook-with-args 'rcirc-activity-hooks buffer)) --- 1501,1507 ---- (let ((t1 (with-current-buffer b1 rcirc-last-post-time)) (t2 (with-current-buffer b2 rcirc-last-post-time))) (time-less-p t2 t1))))) ! (add-to-list 'rcirc-activity-types type) (rcirc-update-activity-string))) (run-hook-with-args 'rcirc-activity-hooks buffer))