Re: rcirc bug

[Ryan Yeske <rcyeske@gmail.com>]

   From: "Alfred M. Szmidt" <ams@gnu.org>
   CC: emacs-devel@gnu.org
   Reply-to: ams@gnu.org
   Date: Tue,  5 Sep 2006 23:37:20 +0200 (CEST)

      > rcirc tries to use member* without (require 'cl), which causes
      > breakage.

      The following patch fixes this:

   I don't think it will fix the problem in full; pushnew is also a 'cl
   macro.  Maybe just changing pushnew to add-to-list would work?  I
   don't know if there are more 'cl-isms in rcirc...

That is true, case seems to be fine, pushnew is the culprit, as it
the function cl-adjoin is called, which includes member*.

I believe this is the correct fix:

*** rcirc.el	05 Sep 2006 12:14:49 -0700	1.26
--- rcirc.el	07 Sep 2006 15:56:32 -0700	
***************
*** 1495,1501 ****
  		    (let ((t1 (with-current-buffer b1 rcirc-last-post-time))
  			  (t2 (with-current-buffer b2 rcirc-last-post-time)))
  		      (time-less-p t2 t1)))))
!       (pushnew type rcirc-activity-types)
        (rcirc-update-activity-string)))
    (run-hook-with-args 'rcirc-activity-hooks buffer))
  
--- 1501,1507 ----
  		    (let ((t1 (with-current-buffer b1 rcirc-last-post-time))
  			  (t2 (with-current-buffer b2 rcirc-last-post-time)))
  		      (time-less-p t2 t1)))))
!       (add-to-list 'rcirc-activity-types type)
        (rcirc-update-activity-string)))
    (run-hook-with-args 'rcirc-activity-hooks buffer))