Re: [christopher.ian.moore@gmail.com: Re: woman loops forever if man page doesn't end with newline]

[Chong Yidong <cyd@stupidchicken.com>]

Richard Stallman <rms@gnu.org> writes:

> Would someone please install this?

I installed a different fix about two weeks ago.

> From: Chris Moore <christopher.ian.moore@gmail.com>
> Subject: Re: woman loops forever if man page doesn't end with newline
> To: emacs-pretest-bug <emacs-pretest-bug@gnu.org>
>
>
> - --=-XeAiEm9IJt54bEXuslkK
> Content-Type: text/plain
> Content-Transfer-Encoding: 7bit
>
> Here's a patch to fix this.  It adds a newline to the end of the man
> page whether or not there's one there already.
>
> Chris.
>
> On Fri, 2006-10-13 at 16:29 +0200, Chris Moore wrote:
>> If a man page doesn't have a terminating newline, then M-x woman RET
>> <page> RET will go into an infinite loop.
>> 
>> For example, this 2 line man page:
>> 
>> ------------------------------------------------------------------------
>> .SH OVERVIEW
>> Oops
>> ------------------------------------------------------------------------
>> 
>> will trigger the bug, if the newline after "Oops" is omitted.
>> 
>> When testing this, use fundamental-mode to create the file because
>> nroff mode will add the final newline automatically when the file is
>> saved.
>> 
>> I discovered the bug when trying to view Debian unstable's 'svn.1' man
>> page.
>> 
>> The package is here:
>> 
>> http://ftp.debian.org/debian/pool/main/s/subversion/subversion_1.4.0-4_i386.deb
>> 
>> and the man page is here:
>>   /usr/share/man/man1/svn.1.gz
>> 
>> 
>> I'll raise a separate bug against the subversion package in the Debian
>> BTS, but woman shouldn't hang in this case anyway.
>> 
>> 
>> 
>> In GNU Emacs 22.0.50.168 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
>>  of 2006-10-12 on chrislap
>> X server distributor `The X.Org Foundation', version 11.0.70101000
>> configured using `configure '--with-gtk' '--with-xpm' '--with-jpeg'
>> '--with-png' '--with-gif''
>> 
>> Important settings:
>>   value of $LC_ALL: en_GB.UTF-8
>>   value of $LC_COLLATE: nil
>>   value of $LC_CTYPE: nil
>>   value of $LC_MESSAGES: nil
>>   value of $LC_MONETARY: nil
>>   value of $LC_NUMERIC: nil
>>   value of $LC_TIME: nil
>>   value of $LANG: en_GB.UTF-8
>>   locale-coding-system: utf-8
>>   default-enable-multibyte-characters: t
>> 
>> Major mode: Fundamental
>> 
>> Minor modes in effect:
>>   show-paren-mode: t
>>   display-time-mode: t
>>   iswitchb-mode: t
>>   dynamic-completion-mode: t
>>   shell-dirtrack-mode: t
>>   tooltip-mode: t
>>   mouse-wheel-mode: t
>>   file-name-shadow-mode: t
>>   global-font-lock-mode: t
>>   font-lock-mode: t
>>   unify-8859-on-encoding-mode: t
>>   utf-translate-cjk-mode: t
>>   auto-compression-mode: t
>>   column-number-mode: t
>>   line-number-mode: t
>>   transient-mark-mode: t
>> 
>
> - --=-XeAiEm9IJt54bEXuslkK
> Content-Disposition: attachment; filename=woman.txt
> Content-Type: text/x-patch; name=woman.txt; charset=utf-8
> Content-Transfer-Encoding: 7bit
>
> - --- old/woman.el	2006-10-24 15:17:50.000000000 +0200
> +++ woman.el	2006-10-24 15:16:47.000000000 +0200
> @@ -1727,7 +1727,10 @@
>  	  (auto-compression-mode 1))
>        (nth 1
>  	   (condition-case ()
> - -	       (insert-file-contents filename nil)
> +	       (progn
> +		 (insert "\n")
> +		 (backward-char 1)
> +		 (insert-file-contents filename nil))
>  	     (file-error
>  	      ;; Run find-file-not-found-hooks until one returns non-nil.
>  	      ;; (run-hook-with-args-until-success 'find-file-not-found-hooks)
>
> - --=-XeAiEm9IJt54bEXuslkK
> Content-Type: text/plain; charset="us-ascii"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
>
> _______________________________________________
> emacs-pretest-bug mailing list
> emacs-pretest-bug@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
>
> - --=-XeAiEm9IJt54bEXuslkK--
> ----------
>
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel