From: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: [affi@csc.no: Calendar hack: Displaying ISO weeks, update for emacs 22]
Date: Sat, 02 Dec 2006 16:40:54 -0500 [thread overview]
Message-ID: <87r6vikmc9.fsf@furball.mit.edu> (raw)
In-Reply-To: <E1GqZ5z-0000bM-5b@fencepost.gnu.org> (Richard Stallman's message of "Sat\, 02 Dec 2006 12\:56\:15 -0500")
Richard Stallman <rms@gnu.org> writes:
> We deleted the variable `facemenu-unlisted-faces' because it didn't do
> anything. But this method shows that we must have lost the
> functionality since 21, and that we need to add it back.
>
> Would someone please reimplement it, then ack?
We deleted it because of a bug report that too many unwanted faces
were added to the facemenu. It's far cleaner to provide a list of
faces to include --- the new variable `facemenu-listed-faces' --- than
a list of faces to exclude.
How about this patch, which defines an obsolete variable
`facemenu-unlisted faces'? It should provide the necessary amount of
backward compatibility to accomodate user code that looks for such a
variable, as in the current bug report.
*** emacs/lisp/facemenu.el.~1.92.~ 2006-11-29 23:19:17.000000000 -0500
--- emacs/lisp/facemenu.el 2006-12-02 16:37:33.000000000 -0500
***************
*** 132,137 ****
--- 132,147 ----
:type 'boolean
:group 'facemenu)
+ (defvar facemenu-unlisted-faces
+ `(modeline region secondary-selection highlight scratch-face
+ ,(purecopy "^font-lock-") ,(purecopy "^gnus-") ,(purecopy "^message-")
+ ,(purecopy "^ediff-") ,(purecopy "^term-") ,(purecopy "^vc-")
+ ,(purecopy "^widget-") ,(purecopy "^custom-") ,(purecopy "^vm-"))
+ "*List of faces that are of no interest to the user.
+ This variable is obsolete, and has no effect on the Face menu.
+ Use the variable `facemenu-listed-faces' instead.")
+ (make-obsolete-variable 'facemenu-unlisted-faces 'facemenu-listed-faces)
+
(defcustom facemenu-listed-faces nil
"*List of faces to include in the Face menu.
Each element should be a symbol, the name of a face.
prev parent reply other threads:[~2006-12-02 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-02 17:56 [affi@csc.no: Calendar hack: Displaying ISO weeks, update for emacs 22] Richard Stallman
2006-12-02 21:40 ` Chong Yidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r6vikmc9.fsf@furball.mit.edu \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).