unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* wdired-use-dired-vertical-movement docstring improvements
@ 2007-11-05  9:56 Chris Moore
  2007-11-05 11:51 ` Thien-Thi Nguyen
  2007-11-06  2:15 ` Richard Stallman
  0 siblings, 2 replies; 4+ messages in thread
From: Chris Moore @ 2007-11-05  9:56 UTC (permalink / raw)
  To: emacs-pretest-bug

`sometimes' is missing its closing quote, and the docstring talks
about "if `track-eol' is honored" - well, isn't it always honored,
like all variables are?  Here's a patch.  Note that the docstring
still isn't quite right, because track-eol seems to have no effect on
the behavior.  Well, I have it set to the default 'nil' and
`sometimes' still works for me.

Chris.

*** a/wdired.el	Mon Nov  5 10:51:32 2007
--- b/wdired.el	Mon Nov  5 10:52:21 2007
***************
*** 130,137 ****
    "If t, the \"up\" and \"down\" movement works as in Dired mode.
  That is, always move the point to the beginning of the filename at line.

! If `sometimes, only move to the beginning of filename if the point is
! before it, and `track-eol' is honored.  This behavior is very handy
  when editing several filenames.

  If nil, \"up\" and \"down\" movement is done as in any other buffer."
--- 130,137 ----
    "If t, the \"up\" and \"down\" movement works as in Dired mode.
  That is, always move the point to the beginning of the filename at line.

! If `sometimes', only move to the beginning of filename if the point is
! before it, and `track-eol' is non-nil.  This behavior is very handy
  when editing several filenames.

  If nil, \"up\" and \"down\" movement is done as in any other buffer."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: wdired-use-dired-vertical-movement docstring improvements
  2007-11-05  9:56 wdired-use-dired-vertical-movement docstring improvements Chris Moore
@ 2007-11-05 11:51 ` Thien-Thi Nguyen
  2007-11-06  2:15 ` Richard Stallman
  1 sibling, 0 replies; 4+ messages in thread
From: Thien-Thi Nguyen @ 2007-11-05 11:51 UTC (permalink / raw)
  To: Chris Moore; +Cc: emacs-pretest-bug

() "Chris Moore" <christopher.ian.moore@gmail.com>
() Mon, 5 Nov 2007 10:56:17 +0100

   ! If `sometimes', only move to the beginning of filename if the point is
   ! before it, and `track-eol' is non-nil.  This behavior is very handy
     when editing several filenames.

installed, thanks.

thi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: wdired-use-dired-vertical-movement docstring improvements
  2007-11-05  9:56 wdired-use-dired-vertical-movement docstring improvements Chris Moore
  2007-11-05 11:51 ` Thien-Thi Nguyen
@ 2007-11-06  2:15 ` Richard Stallman
  2007-11-10  5:04   ` Chris Moore
  1 sibling, 1 reply; 4+ messages in thread
From: Richard Stallman @ 2007-11-06  2:15 UTC (permalink / raw)
  To: Chris Moore; +Cc: emacs-pretest-bug

    `sometimes' is missing its closing quote, and the docstring talks
    about "if `track-eol' is honored" - well, isn't it always honored,
    like all variables are?

Maybe the "if" is the error.  Maybe what it should say is "in addition,
this obeys `track-eol'."

What does the code say?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: wdired-use-dired-vertical-movement docstring improvements
  2007-11-06  2:15 ` Richard Stallman
@ 2007-11-10  5:04   ` Chris Moore
  0 siblings, 0 replies; 4+ messages in thread
From: Chris Moore @ 2007-11-10  5:04 UTC (permalink / raw)
  To: rms; +Cc: emacs-pretest-bug

On Nov 6, 2007 3:15 AM, Richard Stallman <rms@gnu.org> wrote:
>     `sometimes' is missing its closing quote, and the docstring talks
>     about "if `track-eol' is honored" - well, isn't it always honored,
>     like all variables are?
>
> Maybe the "if" is the error.  Maybe what it should say is "in addition,
> this obeys `track-eol'."
>
> What does the code say?

The code doesn't mention track-eol.  It is honored though, so your
guess seems to be correct, and the docstring should read:

If `sometimes', only move to the beginning of filename if the point is
before it.  `track-eol' is honored.  This behavior is very handy when
editing several filenames.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-11-10  5:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-05  9:56 wdired-use-dired-vertical-movement docstring improvements Chris Moore
2007-11-05 11:51 ` Thien-Thi Nguyen
2007-11-06  2:15 ` Richard Stallman
2007-11-10  5:04   ` Chris Moore

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).