* Patch for #3865: Would somebody please commit on HEAD and branch?
@ 2009-07-17 18:51 Tassilo Horn
2009-07-17 19:17 ` Bastien
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Tassilo Horn @ 2009-07-17 18:51 UTC (permalink / raw)
To: emacs-devel; +Cc: 3865
Hi all,
this patch fixes the inconveniences Reiner pointed out in #3865. Could
somebody please commit it for me on branch and head?
I'm to busy to read up how to merge between branches with CVS -- I'm
going to marry tomorrow! :-)
--8<---------------cut here---------------start------------->8---
2009-07-16 Tassilo Horn <tassilo@member.fsf.org>
* doc-view.el (doc-view-initiate-display): Add yes-or-no-p if
rendering of pngs is not possible instead of messaging a long
description.
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
Index: lisp/doc-view.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/doc-view.el,v
retrieving revision 1.87
diff -u -r1.87 doc-view.el
--- lisp/doc-view.el 2 Apr 2009 21:12:56 -0000 1.87
+++ lisp/doc-view.el 17 Jul 2009 18:44:18 -0000
@@ -1078,15 +1078,12 @@
"editing or viewing the document."))))
(message
"%s"
- (substitute-command-keys
- (concat "No PNG support available or some conversion utility for "
- (file-name-extension doc-view-buffer-file-name)" files is missing. "
- "Type \\[doc-view-toggle-display] to switch to "
- (if (eq doc-view-doc-type 'ps)
- "ps-mode"
- "fundamental-mode")
- ", \\[doc-view-open-text] to show the doc as text in a separate buffer "
- " or \\[doc-view-kill-proc-and-buffer] to kill this buffer.")))))
+ (concat "No PNG support available or some conversion utility for "
+ (file-name-extension doc-view-buffer-file-name) " files is missing."))
+ (if (and (executable-find doc-view-pdftotext-program)
+ (yes-or-no-p "Cannot render file. View extracted text instead? "))
+ (doc-view-open-text)
+ (doc-view-toggle-display))))
(defvar bookmark-make-record-function)
--8<---------------cut here---------------end--------------->8---
Bye,
Tassilo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Patch for #3865: Would somebody please commit on HEAD and branch?
2009-07-17 18:51 Patch for #3865: Would somebody please commit on HEAD and branch? Tassilo Horn
@ 2009-07-17 19:17 ` Bastien
2009-07-17 19:34 ` Lennart Borgman
2009-07-17 19:47 ` Tassilo Horn
2009-07-17 19:44 ` Chong Yidong
2009-07-19 5:34 ` Stefan Monnier
2 siblings, 2 replies; 7+ messages in thread
From: Bastien @ 2009-07-17 19:17 UTC (permalink / raw)
To: emacs-devel; +Cc: 3865
Tassilo Horn <tassilo@member.fsf.org> writes:
> this patch fixes the inconveniences Reiner pointed out in #3865. Could
> somebody please commit it for me on branch and head?
I'm willing to do this.
> I'm to busy to read up how to merge between branches with CVS -- I'm
> going to marry tomorrow! :-)
I also need to learn how to do this. Pointers anyone?
--
Bastien
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Patch for #3865: Would somebody please commit on HEAD and branch?
2009-07-17 19:17 ` Bastien
@ 2009-07-17 19:34 ` Lennart Borgman
2009-07-17 19:47 ` Tassilo Horn
1 sibling, 0 replies; 7+ messages in thread
From: Lennart Borgman @ 2009-07-17 19:34 UTC (permalink / raw)
To: Bastien; +Cc: Emacs-Devel devel
On Fri, Jul 17, 2009 at 9:17 PM, Bastien<bastienguerry@googlemail.com> wrote:
> Tassilo Horn <tassilo@member.fsf.org> writes:
>
>> I'm to busy to read up how to merge between branches with CVS -- I'm
>> going to marry tomorrow! :-)
>
> I also need to learn how to do this. Pointers anyone?
Go out, meet some people have fun... ;-)
Good luck, Tassilo!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Patch for #3865: Would somebody please commit on HEAD and branch?
2009-07-17 18:51 Patch for #3865: Would somebody please commit on HEAD and branch? Tassilo Horn
2009-07-17 19:17 ` Bastien
@ 2009-07-17 19:44 ` Chong Yidong
2009-07-19 5:34 ` Stefan Monnier
2 siblings, 0 replies; 7+ messages in thread
From: Chong Yidong @ 2009-07-17 19:44 UTC (permalink / raw)
To: emacs-devel; +Cc: 3865-done
Tassilo Horn <tassilo@member.fsf.org> writes:
> this patch fixes the inconveniences Reiner pointed out in #3865. Could
> somebody please commit it for me on branch and head?
I've checked it into the trunk. I don't think this is serious enough to
commit to the branch.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Patch for #3865: Would somebody please commit on HEAD and branch?
2009-07-17 19:17 ` Bastien
2009-07-17 19:34 ` Lennart Borgman
@ 2009-07-17 19:47 ` Tassilo Horn
2009-07-18 5:51 ` Bastien
1 sibling, 1 reply; 7+ messages in thread
From: Tassilo Horn @ 2009-07-17 19:47 UTC (permalink / raw)
To: Bastien; +Cc: emacs-devel
Bastien <bastienguerry@googlemail.com> writes:
Hi Bastien,
>> this patch fixes the inconveniences Reiner pointed out in #3865.
>> Could somebody please commit it for me on branch and head?
>
> I'm willing to do this.
Thanks.
>> I'm to busy to read up how to merge between branches with CVS -- I'm
>> going to marry tomorrow! :-)
>
> I also need to learn how to do this. Pointers anyone?
Well, in general you first have to look for a woman... :-P
Bye,
Tassilo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Patch for #3865: Would somebody please commit on HEAD and branch?
2009-07-17 19:47 ` Tassilo Horn
@ 2009-07-18 5:51 ` Bastien
0 siblings, 0 replies; 7+ messages in thread
From: Bastien @ 2009-07-18 5:51 UTC (permalink / raw)
To: emacs-devel
Tassilo Horn <tassilo@member.fsf.org> writes:
>> I also need to learn how to do this. Pointers anyone?
>
> Well, in general you first have to look for a woman... :-P
:)
--
Bastien
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Patch for #3865: Would somebody please commit on HEAD and branch?
2009-07-17 18:51 Patch for #3865: Would somebody please commit on HEAD and branch? Tassilo Horn
2009-07-17 19:17 ` Bastien
2009-07-17 19:44 ` Chong Yidong
@ 2009-07-19 5:34 ` Stefan Monnier
2 siblings, 0 replies; 7+ messages in thread
From: Stefan Monnier @ 2009-07-19 5:34 UTC (permalink / raw)
To: emacs-devel; +Cc: 3865
> + (if (and (executable-find doc-view-pdftotext-program)
> + (yes-or-no-p "Cannot render file. View extracted text instead? "))
> + (doc-view-open-text)
> + (doc-view-toggle-display))))
Please avoid modal UIs wherever possible. E.g. rather than ask with
yes-or-no-p, just choose one of the two branches (maybe based on
a config var) and output a message explaining how to get the
other branch.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-07-19 5:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-17 18:51 Patch for #3865: Would somebody please commit on HEAD and branch? Tassilo Horn
2009-07-17 19:17 ` Bastien
2009-07-17 19:34 ` Lennart Borgman
2009-07-17 19:47 ` Tassilo Horn
2009-07-18 5:51 ` Bastien
2009-07-17 19:44 ` Chong Yidong
2009-07-19 5:34 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).