From: Karl Fogel <kfogel@red-bean.com>
To: emacs-devel@gnu.org
Subject: Better subjects, bodies for commit diff emails?
Date: Wed, 13 Jan 2010 14:29:56 -0500 [thread overview]
Message-ID: <87r5ptpzuz.fsf@red-bean.com> (raw)
Our commit diff emails currently have subject lines like this:
"[Emacs-diffs] /srv/bzr/emacs/trunk r99318: Fix gc bug in terminal allocation."
They would be better like this, I think:
"[Emacs-diffs] r99318: Fix gc bug in terminal allocation."
The "/srv/bzr/emacs/trunk" is pretty much wasted space. Do we even send
commit emails for other branches? I don't know, but if we don't, then
there's no need to take up space saying the branch; and if we do, then
we could just say "trunk" or "foo" without the "/srv/bzr/emacs/" prefix.
Meanwhile, in the message body, adding some vertical whitepace would
make improve readability. I'll mark my suggestions below with "###":
revno: 99318
committer: Chong Yidong <cyd@stupidchicken.com>
branch nick: trunk
timestamp: Wed 2010-01-13 13:35:36 -0500
message:
Fix gc bug in terminal allocation.
* xterm.c (x_term_init): Avoid garbage-collecting the new terminal
during call to vendor-specific-keysyms (Bug#5365).
### How about a blank line here? Currently there is not one. ###
modified:
src/ChangeLog
src/xterm.c
### And how about a blank line here? Currently there is not one. ###
=== modified file 'src/ChangeLog'
--- a/src/ChangeLog 2010-01-13 04:42:45 +0000
+++ b/src/ChangeLog 2010-01-13 18:35:36 +0000
### After this point, there are blank lines between hunks, so all good ##
I don't know what would be involved in fixing these problems. I presume
a Savannah support request for at least the first, and either a Savannah
SR and/or a patch to some Bazaar tool for the latter.
If people agree that these would be good, I (might :-) ) take a look.
Thoughts?
-Karl
next reply other threads:[~2010-01-13 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 19:29 Karl Fogel [this message]
2010-01-13 19:38 ` Better subjects, bodies for commit diff emails? Dan Nicolaescu
2010-01-13 21:25 ` Karl Fogel
2010-01-13 21:26 ` Glenn Morris
2010-01-14 18:35 ` Eli Zaretskii
2010-01-14 19:23 ` Karl Fogel
2010-01-13 20:09 ` Glenn Morris
2010-01-13 20:32 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5ptpzuz.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).