unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Antoine Levitt <antoine.levitt@gmail.com>
To: emacs-devel@gnu.org
Subject: [PATCH] erc-track erases the modeline when new buffers are created
Date: Fri, 13 Aug 2010 23:57:02 +0100	[thread overview]
Message-ID: <87r5i26s01.fsf@gmail.com> (raw)

When a new ERC buffer is created (for instance, a query) while erc-track
displays information in the mode line, the information is removed. I
tracked the bug down to an initialisation of
erc-modified-channels-object each time erc-track-mode is activated (ie,
each time an ERC buffer is created). This is useless because the
variable is initialised at load time with (defvar).

This patch simply removes the extra initialisation. I tested it, it
works for me and I don't see any potential bugs the removal might cause.

Antoine Levitt

=== modified file 'lisp/erc/erc-track.el'
--- lisp/erc/erc-track.el	2010-01-13 08:35:10 +0000
+++ lisp/erc/erc-track.el	2010-08-13 22:47:20 +0000
@@ -649,7 +649,6 @@
 	   (add-hook 'erc-send-completed-hook 'erc-user-is-active)
 	   (add-hook 'erc-server-001-functions 'erc-user-is-active))
        (erc-track-add-to-mode-line erc-track-position-in-mode-line)
-       (setq erc-modified-channels-object (erc-modified-channels-object nil))
        (erc-update-mode-line)
        (if (featurep 'xemacs)
 	   (defadvice switch-to-buffer (after erc-update (&rest args) activate)




             reply	other threads:[~2010-08-13 22:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13 22:57 Antoine Levitt [this message]
2011-01-31 18:16 ` [PATCH] erc-track erases the modeline when new buffers are created Michael Olson
2011-01-31 19:16   ` Chong Yidong
2011-01-31 19:27   ` Chong Yidong
  -- strict thread matches above, loose matches on Subject: below --
2011-01-28 22:58 Thomas Riccardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r5i26s01.fsf@gmail.com \
    --to=antoine.levitt@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).