unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stephen J. Turnbull" <stephen@xemacs.org>
To: Glenn Morris <rgm@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.
Date: Mon, 25 Oct 2010 17:03:40 +0900	[thread overview]
Message-ID: <87r5fed7hf.fsf@uwakimon.sk.tsukuba.ac.jp> (raw)
In-Reply-To: <bb4ocaswdj.fsf@fencepost.gnu.org>

Glenn Morris writes:

 > I find it weird that when faced with the issue "we need to define a
 > function, eg x-display-list, on multiple platforms; it should have the
 > same arguments, doc-string, and behaviour on each platform" that Emacs
 > consistently chose to have three completely separate definitions in
 > three separate files; rather than just having one with #ifdefs for
 > each platform where needed.

Some such strategy is necessary if you are going to support different
console types in the same binary.  Eg, it is possible to support both
native MS Windows displays and X displays at the same time.

It's true that for very similar display types such as Xt and GTK+
where much of the code can be reused[1], it may make sense to create a
single file with the common code, and include it multiple times with
preprocessor tweaking to make the names fit and to register driver
functions in the right tables.  But there's no point in this for X
drivers vs. MS Windows drivers; they're going to have very little
common code.

Footnotes: 
[1]  Whether that's a good idea or not is a separate question.




  reply	other threads:[~2010-10-25  8:03 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1P9lT2-0005WD-37@internal.in.savannah.gnu.org>
     [not found] ` <jwvmxq4pez1.fsf-monnier+emacs@gnu.org>
2010-10-24  2:02   ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Glenn Morris
2010-10-24  5:08     ` Dan Nicolaescu
2010-10-24 19:45       ` Glenn Morris
2010-10-25 13:25         ` Adrian Robert
2010-10-25 14:51           ` Dan Nicolaescu
2010-10-26  2:59             ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-26  4:25               ` ns-win.el Glenn Morris
2010-10-26  4:54                 ` ns-win.el CHENG Gao
2010-10-26  5:10                 ` ns-win.el Adrian Robert
2010-10-26 15:18                 ` ns-win.el Stefan Monnier
2010-10-26  5:07               ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Adrian Robert
2010-10-26  6:45                 ` ns-win.el Glenn Morris
2010-10-26  7:47                   ` ns-win.el Eli Zaretskii
2010-10-26 10:49                   ` ns-win.el Adrian Robert
2010-10-26 15:27                     ` ns-win.el Stefan Monnier
2010-10-26 19:25                       ` ns-win.el Glenn Morris
2010-10-26 19:57                         ` ns-win.el Adrian Robert
2010-10-26  6:50                 ` ns-win.el Glenn Morris
2010-10-26  7:49                   ` ns-win.el Eli Zaretskii
2010-10-26 13:08                     ` ns-win.el Ted Zlatanov
2010-10-26 14:42                       ` ns-win.el Eli Zaretskii
2010-10-26 17:35                         ` ns-win.el Ted Zlatanov
2010-10-26  7:32                 ` ns-win.el Daniel Pittman
2010-10-24  7:55     ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Eli Zaretskii
2010-10-24 19:47       ` Glenn Morris
2010-10-25  0:54         ` Stefan Monnier
2010-10-25  4:56           ` Glenn Morris
2010-10-25  8:03             ` Stephen J. Turnbull [this message]
2010-10-25  9:28               ` Eli Zaretskii
2010-10-25  8:20             ` Eli Zaretskii
2010-10-28  3:54           ` moving x-select* [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-28  4:06             ` Eli Zaretskii
2010-10-28  5:32               ` Jason Rumney
2010-10-28  6:40                 ` Chad Brown
2010-10-28 13:54                   ` moving x-select* Jason Rumney
2010-10-28 15:28                     ` Chad Brown
2010-10-28 14:23             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r5fed7hf.fsf@uwakimon.sk.tsukuba.ac.jp \
    --to=stephen@xemacs.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).