From: Thien-Thi Nguyen <ttn@gnuvola.org>
To: Chong Yidong <cyd@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Security flaw in enable-local-eval; new release plan
Date: Mon, 13 Aug 2012 08:32:57 +0200 [thread overview]
Message-ID: <87r4rbjo86.fsf@zigzag.favinet> (raw)
In-Reply-To: <87obmfsczi.fsf@gnu.org> (Chong Yidong's message of "Mon, 13 Aug 2012 11:10:57 +0800")
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
() Chong Yidong <cyd@gnu.org>
() Mon, 13 Aug 2012 11:10:57 +0800
(let ((safe (or (hack-one-local-variable-eval-safep
(eval (quote val)))
;; In case previously marked safe (bug#5636).
(safe-local-variable-p var val))))
;; If not safe and e-l-v = :safe, ignore totally.
(when (or safe (not (eq enable-local-variables :safe)))
(push elt all-vars)
(or (eq enable-local-eval t)
safe
(push elt unsafe-vars))))
It seems control reaches ‘eval’ before reaching the ‘:safe’ check, thus
defeating the check. Am i missing something?
--
Thien-Thi Nguyen ..................................... GPG key: 4C807502
. NB: ttn at glug dot org is not me .
. (and has not been since 2007 or so) .
. ACCEPT NO SUBSTITUTES .
........... please send technical questions to mailing lists ...........
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2012-08-13 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 3:10 Security flaw in enable-local-eval; new release plan Chong Yidong
2012-08-13 6:32 ` Thien-Thi Nguyen [this message]
2012-08-13 12:45 ` Herring, Davis
2012-08-13 6:49 ` Glenn Morris
2012-08-13 8:06 ` Ulrich Mueller
2012-08-14 4:07 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4rbjo86.fsf@zigzag.favinet \
--to=ttn@gnuvola.org \
--cc=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).