From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Feature freeze on October 1 Date: Mon, 01 Oct 2012 00:27:04 +0900 Message-ID: <87r4pj8rav.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349018848 28078 80.91.229.3 (30 Sep 2012 15:27:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Sep 2012 15:27:28 +0000 (UTC) Cc: eliz@gnu.org, cyd@gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 30 17:27:33 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TILQa-0005B2-Ok for ged-emacs-devel@m.gmane.org; Sun, 30 Sep 2012 17:27:32 +0200 Original-Received: from localhost ([::1]:52661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TILQV-00031a-7c for ged-emacs-devel@m.gmane.org; Sun, 30 Sep 2012 11:27:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TILQT-00031V-6C for emacs-devel@gnu.org; Sun, 30 Sep 2012 11:27:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TILQS-0001Oy-1Z for emacs-devel@gnu.org; Sun, 30 Sep 2012 11:27:25 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:35103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TILQR-0001Ou-Uh for emacs-devel@gnu.org; Sun, 30 Sep 2012 11:27:23 -0400 Original-Received: from 253.240.accsnet.ne.jp ([202.220.240.253]:62863 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TILQQ-0006Rx-Uo; Sun, 30 Sep 2012 11:27:23 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 27 Sep 2012 08:57:23 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153757 Archived-At: In article , Stefan Monnier writes: > > And I'm not sure that all calls to decode_char are prepared > > to buffer/string relocation. > String relocation only happens during GC, which normally only happens > during Elisp evaluation, so that shouldn't be an issue. I see. > But, yes, it seems that ccl.c and maybe coding.c both have uses of > decode_char where buffer relocation can cause problems In ccl.c, ccl_driver uses DECODE_CHAR, and ccl_driver itself has no problem because it doesn't uses a pointer into buffer/string. But, I noticed that the callers of that function in coding.c (decode_coding_ccl and encode_coding_ccl) has to prepare for buffer relocation. I've just installed a fix. > (CODING_DECODE_CHAR seems to try and handle it explicitly, but I'm not > sure it's sufficient). At least, it should be sufficient for pointers used by code conversion routines. Isn't it? --- Kenichi Handa handa@gnu.org