unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Meyering <jim@meyering.net>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	Emacs Development <Emacs-devel@gnu.org>
Subject: Re: (0 <= i && i < N) is not "backwards"
Date: Sat, 30 Mar 2013 22:45:52 +0100	[thread overview]
Message-ID: <87r4iwftnz.fsf@rho.meyering.net> (raw)
In-Reply-To: <514F88E9.2020600@cs.ucla.edu> (Paul Eggert's message of "Sun, 24 Mar 2013 16:14:49 -0700")

Paul Eggert wrote:
> Emacs trunk bzr 112126, installed with the commit log
> "Reorder conditions that are written backwards",
> changed a lot of Emacs code, typically to replace expressions
> like "0 < i" with expressions like "i > 0".
>
> This sort of stylistic change shouldn't be introduced without
> discussion.  I often prefer "<", as it causes textual

I was surprised to see that commit, and came to this list to find
the discussion that happened prior to the global style conversion.
Considering that there was no discussion, a snap revert would be fair.

Full disclosure: I too prefer the "use < and <= everywhere" style,
and mention it in the GNU coreutils' HACKING guidelines:

  http://git.savannah.gnu.org/cgit/coreutils.git/tree/HACKING#n412


Jim



      parent reply	other threads:[~2013-03-30 21:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-24 23:14 (0 <= i && i < N) is not "backwards" Paul Eggert
2013-03-24 23:53 ` Pascal J. Bourguignon
2013-03-25 14:23   ` Stefan Monnier
2013-03-25 14:59     ` Andreas Schwab
2013-03-25  8:20 ` Eli Zaretskii
2013-03-25 14:35   ` Paul Eggert
2013-03-25 14:53     ` Eli Zaretskii
2013-03-25 14:58       ` Noah Lavine
2013-03-25 15:09         ` Eli Zaretskii
2013-03-25 15:28           ` Noah Lavine
2013-03-25 16:49       ` Paul Eggert
2013-03-25 16:59         ` Eli Zaretskii
2013-03-30 21:45 ` Jim Meyering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4iwftnz.fsf@rho.meyering.net \
    --to=jim@meyering.net \
    --cc=Emacs-devel@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).