From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: GNU Emacs-libnettle-libhogweed integration patch v1 Date: Sun, 06 Oct 2013 17:07:32 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87r4byp0q3.fsf@flea.lifelogs.com> References: <877gdqrc9u.fsf@flea.lifelogs.com> <83wqlq5qka.fsf@gnu.org> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1381093678 28737 80.91.229.3 (6 Oct 2013 21:07:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Oct 2013 21:07:58 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 06 23:08:01 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VSvYX-0003fu-8j for ged-emacs-devel@m.gmane.org; Sun, 06 Oct 2013 23:08:01 +0200 Original-Received: from localhost ([::1]:56440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSvYW-0007yn-LT for ged-emacs-devel@m.gmane.org; Sun, 06 Oct 2013 17:08:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSvYN-0007yS-OR for emacs-devel@gnu.org; Sun, 06 Oct 2013 17:07:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VSvYH-0004H5-OW for emacs-devel@gnu.org; Sun, 06 Oct 2013 17:07:51 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:35240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSvYH-0004Gw-GG for emacs-devel@gnu.org; Sun, 06 Oct 2013 17:07:45 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1VSvYB-0003Y3-S1 for emacs-devel@gnu.org; Sun, 06 Oct 2013 23:07:39 +0200 Original-Received: from c-98-229-61-72.hsd1.ma.comcast.net ([98.229.61.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 06 Oct 2013 23:07:39 +0200 Original-Received: from tzz by c-98-229-61-72.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 06 Oct 2013 23:07:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 54 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-98-229-61-72.hsd1.ma.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:hxdRCPhRowdO+wFSL8sRMZWDZtc= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163929 Archived-At: On Sun, 06 Oct 2013 19:09:41 +0300 Eli Zaretskii wrote: EZ> For the record: this will have to be changed for MS-Windows, to EZ> support dynamic loading, like we do, e.g., in decompress.c. Yup, I figured it would, but I don't know that part of the code well. >> +DEFUN ("nettle-hmac", Fnettle_hmac, Snettle_hmac, 3, 3, 0, >> + doc: /* Hash INPUT string with HASH-METHOD and KEY into a unibyte string according to HMAC (RFC 2104). EZ> The first line of the doc string is too long. (There are others with EZ> similar problems.) OK, redone. One just can't be shortened easily: Make PBKDF2 of HASH-LENGTH from KEY with HASH-METHOD using ITERATIONS and SALT. EZ> Instead of xzalloc, then make_unibyte_string, I think you should be EZ> able to allocate a string first, and then work on its SDATA. This EZ> will save you from at least one allocation. Hmm, I thought about that, but typically Nettle wants to work on pure C strings and it's nice to avoid corrupting Lisp strings. Other than saving the allocation, are there other benefits? EZ> We tend to use xfree, not free. OK; fixed. >> + sha1_mode = 0 == strcmp (SDATA (hash_method), "sha1"); >> + sha256_mode = 0 == strcmp (SDATA (hash_method), "sha256"); EZ> Perhaps using Fstring_equal is better here, not sure. OK with me either way. I didn't want to use symbols because Nettle uses strings... but maybe symbols are the right approach anyhow. >> + uint8_t *digest = xzalloc (outlength); EZ> ^^^^^^^ EZ> Why not 'unsigned char'? Nettle uses those. >> + if (!rsa_keypair_from_der (&key, NULL, 0, SCHARS (public_key), SDATA (public_key)) && >> + !rsa_keypair_from_sexp (&key, NULL, 0, SCHARS (public_key), SDATA (public_key))) EZ> The && should be at the beginning of a line, not at the end. Oh, I always forget that. Fixed. I won't post the revised patch, it's too trivial :) But I could publish the branch in the Emacs repo if it's OK with you and/or Stefan? Ted