From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Mopre fun with vcswitness Date: Sun, 12 Jan 2014 22:30:31 +0100 Message-ID: <87r48cc2h4.fsf@fencepost.gnu.org> References: <20140112200736.C29B33811D4@snark.thyrsus.com> <87zjn1ar8z.fsf@fencepost.gnu.org> <83k3e47vlq.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389562417 27176 80.91.229.3 (12 Jan 2014 21:33:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 12 Jan 2014 21:33:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 12 22:33:44 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W2Sf9-0002c7-Ed for ged-emacs-devel@m.gmane.org; Sun, 12 Jan 2014 22:33:43 +0100 Original-Received: from localhost ([::1]:39532 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2Sf4-0005ds-So for ged-emacs-devel@m.gmane.org; Sun, 12 Jan 2014 16:33:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2Sf1-0005cw-Vr for emacs-devel@gnu.org; Sun, 12 Jan 2014 16:33:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2Sf1-0005uX-1E for emacs-devel@gnu.org; Sun, 12 Jan 2014 16:33:35 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2Sc4-00059t-7b for emacs-devel@gnu.org; Sun, 12 Jan 2014 16:30:32 -0500 Original-Received: from localhost ([127.0.0.1]:52860 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2Sc3-0001uX-KW; Sun, 12 Jan 2014 16:30:31 -0500 Original-Received: by lola (Postfix, from userid 1000) id 38C90E0463; Sun, 12 Jan 2014 22:30:31 +0100 (CET) In-Reply-To: <83k3e47vlq.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Jan 2014 23:12:33 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168251 Archived-At: Eli Zaretskii writes: >> From: David Kastrup >> Date: Sun, 12 Jan 2014 21:18:20 +0100 >> >> The overall look is highly suspicious for srcdir being different >> from . > > srcdir should always be a relative file name, like ../foo, never > absolute. > > Does it still look suspicious under that assumption? Yes. I am not saying "guilty", I am saying "suspicious". While the U.S. justice system makes it very expensive to get differentiation between "guilty" and "suspicious", it's still a valid distinction. But it looks filthy enough to be viewed as within three hops of a genuine bug. At any rate, even with relative paths I'd not expect to see VCSWITNESS: $(srcdir)/../.bzr/checkout/dirstate but rather VCSWITNESS: ../$(srcdir)/.bzr/checkout/dirstate since it is hard to imagine that the former would work for _anything_ but srcdir=. here. The same holds for the current vcswitness='$$(srcdir)/../'$$dirstate; \ which would seem, used from within the src subdirectory, to have to rather be vcswitness='../$$(srcdir)/'$$dirstate; \ It would seem that srcdir=. is the _only_ value for which this would work. Which is also likely the most common value, namely the one for in-place builds. -- David Kastrup