From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] gnutls: Add SNI support
Date: Mon, 24 Nov 2014 14:08:47 +0100 [thread overview]
Message-ID: <87r3ws3fvk.fsf@toke.dk> (raw)
In-Reply-To: <87oarwhjem.fsf@zigzag.favinet> (Thien-Thi Nguyen's message of "Mon, 24 Nov 2014 13:28:49 +0100")
Thien-Thi Nguyen <ttn@gnu.org> writes:
> Aside from the whitespace and brace placement, this code is buggy: ‘c’
> is of type ‘char *’ and cannot be meaningfully compared directly to
> 'a'.
Ah yes, was missing a pointer deref I guess. But as I noted, there's
probably a better way to check this.
Not sure I'm the right person to integrate this probably; can make it a
feature request instead? Please support SNI... :)
-Toke
next prev parent reply other threads:[~2014-11-24 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 12:17 [PATCH] gnutls: Add SNI support Toke Høiland-Jørgensen
2014-11-24 12:28 ` Thien-Thi Nguyen
2014-11-24 13:08 ` Toke Høiland-Jørgensen [this message]
2014-11-24 14:50 ` Lars Magne Ingebrigtsen
2014-11-24 20:56 ` Florian Weimer
2014-11-24 12:33 ` Jérémie Courrèges-Anglas
2014-11-26 21:52 ` Lars Magne Ingebrigtsen
2014-11-26 22:12 ` Lars Magne Ingebrigtsen
2014-11-27 9:01 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3ws3fvk.fsf@toke.dk \
--to=toke@toke.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).