Re: [Emacs-diffs] master 3953c4b 1/2: Improve tramp-handle-make-auto-save-file-name

Re: [Emacs-diffs] master 3953c4b 1/2: Improve tramp-handle-make-auto-save-file-name

[Dmitry Gutov]

On 05/27/2015 04:48 PM, Michael Albinus wrote:
> branch: master
> commit 3953c4be2816537be95520605d45b866dc731f4b

>      (tramp-handle-make-auto-save-file-name): Let native

This leaves unbalanced parens.

Re: [Emacs-diffs] master 3953c4b 1/2: Improve tramp-handle-make-auto-save-file-name

[Eli Zaretskii]

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 27 May 2015 18:41:19 +0300
> 
> On 05/27/2015 04:48 PM, Michael Albinus wrote:
> > branch: master
> > commit 3953c4be2816537be95520605d45b866dc731f4b
> 
> >      (tramp-handle-make-auto-save-file-name): Let native
> 
> This leaves unbalanced parens.

It's actually the same code added twice.

Re: master abf0823 2/2: New test tramp-test30-make-auto-save-file-name

[Glenn Morris]

>     * tramp-tests.el (tramp-test30-make-auto-save-file-name): New test.
[...]
>    * tramp.el (tramp-auto-save-directory): Add :tags.

Please try to write the full filename relative to top-level.
test/automated/tramp-tests.el etc.

Re: [Emacs-diffs] master 3953c4b 1/2: Improve tramp-handle-make-auto-save-file-name

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

>> On 05/27/2015 04:48 PM, Michael Albinus wrote:
>> > branch: master
>> > commit 3953c4be2816537be95520605d45b866dc731f4b
>> 
>> >      (tramp-handle-make-auto-save-file-name): Let native
>> 
>> This leaves unbalanced parens.
>
> It's actually the same code added twice.

Sorry, it was a merge error when I've taken the code from the Tramp
repository. Shall be fixed now (and hopefully, I haven't added other damages).

Best regards, Michael.

Re: master abf0823 2/2: New test tramp-test30-make-auto-save-file-name

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

>>     * tramp-tests.el (tramp-test30-make-auto-save-file-name): New test.
> [...]
>>    * tramp.el (tramp-auto-save-directory): Add :tags.
>
> Please try to write the full filename relative to top-level.
> test/automated/tramp-tests.el etc.

You are right, but I really hate it that we have no ChangeLog
anymore. It was simple to extract the commit message from the ChangeLog
by "C-c C-a". Now we have to do it by hand, and I tend to fail this exam.

I still don't understand why we have given up ChangeLogs. And yes, I
have read all discussions about. No obvious advantage, from my point of view.

(And no, I don't want to start another endless discussion thread)

Best tregards, Michael.

Re: master abf0823 2/2: New test tramp-test30-make-auto-save-file-name

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Wed, 27 May 2015 18:59:59 +0200
> Cc: emacs-devel@gnu.org
> 
> You are right, but I really hate it that we have no ChangeLog
> anymore. It was simple to extract the commit message from the ChangeLog
> by "C-c C-a". Now we have to do it by hand, and I tend to fail this exam.

Why don't you start a local ChangeLog file?  Git will ignore it.  Then
you could continue doing the same routine.  That's what I do.

Re: master abf0823 2/2: New test tramp-test30-make-auto-save-file-name

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

> Why don't you start a local ChangeLog file?  Git will ignore it.  Then
> you could continue doing the same routine.  That's what I do.

That's an idea, thanks. Will try it.

But isn't it stupid, that we get rid of ChangeLogs, and afterwards
people start to mimic them for convenience?

Best regards, Michael.

Re: master abf0823 2/2: New test tramp-test30-make-auto-save-file-name

[Yuri Khan]

On Wed, May 27, 2015 at 11:39 PM, Michael Albinus
<michael.albinus@gmx.de> wrote:

> But isn't it stupid, that we get rid of ChangeLogs, and afterwards
> people start to mimic them for convenience?

The point of getting rid of changelogs is so that you no longer have
to merge them. And changelogs are a kind of files which are very
conflict-prone.

Re: master abf0823 2/2: New test tramp-test30-make-auto-save-file-name

[Eli Zaretskii]

> From: Yuri Khan <yuri.v.khan@gmail.com>
> Date: Thu, 28 May 2015 00:04:20 +0600
> Cc: Eli Zaretskii <eliz@gnu.org>, Glenn Morris <rgm@gnu.org>, Emacs developers <emacs-devel@gnu.org>
> 
> On Wed, May 27, 2015 at 11:39 PM, Michael Albinus
> <michael.albinus@gmx.de> wrote:
> 
> > But isn't it stupid, that we get rid of ChangeLogs, and afterwards
> > people start to mimic them for convenience?
> 
> The point of getting rid of changelogs is so that you no longer have
> to merge them. And changelogs are a kind of files which are very
> conflict-prone.

Only if you don't have git-merge-changelog installed and configured in
Git.

Re: master abf0823 2/2: New test tramp-test30-make-auto-save-file-name

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: rgm@gnu.org,  emacs-devel@gnu.org
> Date: Wed, 27 May 2015 19:39:48 +0200
> 
> But isn't it stupid, that we get rid of ChangeLogs, and afterwards
> people start to mimic them for convenience?

We didn't get rid of ChangeLogs, we just got rid of having them in the
repository.

Re: master abf0823 2/2: New test tramp-test30-make-auto-save-file-name

[Stefan Monnier]

>> Why don't you start a local ChangeLog file?  Git will ignore it.  Then
>> you could continue doing the same routine.  That's what I do.

Same here.


        Stefan

Re: master abf0823 2/2: New test tramp-test30-make-auto-save-file-name

[Stephen Leake]

Michael Albinus <michael.albinus@gmx.de> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>>>     * tramp-tests.el (tramp-test30-make-auto-save-file-name): New test.
>> [...]
>>>    * tramp.el (tramp-auto-save-directory): Add :tags.
>>
>> Please try to write the full filename relative to top-level.
>> test/automated/tramp-tests.el etc.
>
> You are right, but I really hate it that we have no ChangeLog
> anymore. It was simple to extract the commit message from the ChangeLog
> by "C-c C-a". Now we have to do it by hand, and I tend to fail this
> exam.

We need to bind C-c C-a to do The Right Thing while editing the git
commit log. That is, build the change entry in the git commit log
directly, not in the Changelog file.

I use Emacs DVC (which I also maintain); it does that.

Maybe there already is a key for this in Emacs vc?

-- 
-- Stephe