From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Matthew Leach <matthew@mattleach.net>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH v4] Add systemd socket launching support
Date: Mon, 04 Apr 2016 20:12:43 +0100
Message-ID: <87r3elur10.fsf@mattleach.net>
References: <87lh4t2xun.fsf@mattleach.net> <mvma8l92xna.fsf@hawking.suse.de>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: ger.gmane.org 1459797185 13567 80.91.229.3 (4 Apr 2016 19:13:05 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Mon, 4 Apr 2016 19:13:05 +0000 (UTC)
Cc: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@IRO.UMontreal.CA>,
	emacs-devel <emacs-devel@gnu.org>
To: Andreas Schwab <schwab@suse.de>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 04 21:12:57 2016
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1an9vj-0006Ab-2U
	for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2016 21:12:55 +0200
Original-Received: from localhost ([::1]:60645 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1an9vi-00035c-Hp
	for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2016 15:12:54 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42104)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <matthew@mattleach.net>) id 1an9ve-00035V-H5
	for emacs-devel@gnu.org; Mon, 04 Apr 2016 15:12:51 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <matthew@mattleach.net>) id 1an9vd-0000KU-Pk
	for emacs-devel@gnu.org; Mon, 04 Apr 2016 15:12:50 -0400
Original-Received: from mx0.mattleach.net ([176.58.118.143]:32844)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <matthew@mattleach.net>)
	id 1an9vZ-0000HY-VH; Mon, 04 Apr 2016 15:12:46 -0400
Original-Received: by mx0.mattleach.net (Postfix, from userid 99)
	id 5C91B6222E; Mon,  4 Apr 2016 20:12:45 +0100 (BST)
Original-Received: from matt-desktop.mattleach.net
	(host81-159-23-200.range81-159.btcentralplus.com [81.159.23.200])
	by mx0.mattleach.net (Postfix) with ESMTPSA id E894B62226;
	Mon,  4 Apr 2016 20:12:43 +0100 (BST)
In-Reply-To: <mvma8l92xna.fsf@hawking.suse.de> (Andreas Schwab's message of
	"Mon, 04 Apr 2016 17:37:13 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 176.58.118.143
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:202705
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/202705>

Hi Andreas,

Andreas Schwab <schwab@suse.de> writes:

> Matthew Leach <matthew@mattleach.net> writes:
>
>> +#ifdef HAVE_LIBSYSTEMD
>> +  if (!NILP (use_systemd_socket_p))
>> +    {
>> +      extern int systemd_socket;
>
> External declarations should only be put in headers.

Ah, good spot.  Thanks for the pointer.
-- 
Matt