[PATCH] Call va_end after processing ap

[PATCH] Call va_end after processing ap

[Aaron Conole]

* gnutls.c (boot_error): A recent change added a function to signal an
error or return an error code. That function uses a variadic argument
list to populate an error message string. However, it missed calling
va_end after using the variadic argument list.

---
 src/gnutls.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gnutls.c b/src/gnutls.c
index 57b164a..1089b1a 100644
--- a/src/gnutls.c
+++ b/src/gnutls.c
@@ -1181,6 +1181,7 @@ boot_error (struct Lisp_Process *p, const char *m, ...)
     pset_status (p, list2 (Qfailed, vformat_string (m, ap)));
   else
     verror (m, ap);
+  va_end(ap);
 }
 
 Lisp_Object
-- 
2.5.5

Re: [PATCH] Call va_end after processing ap

[Lars Ingebrigtsen]

Aaron Conole <aconole@redhat.com> writes:

> * gnutls.c (boot_error): A recent change added a function to signal an
> error or return an error code. That function uses a variadic argument
> list to populate an error message string. However, it missed calling
> va_end after using the variadic argument list.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

[PATCH] Call va_end after processing ap

[Aaron Conole]

* gnutls.c (boot_error): A recent change added a function to signal an
error or return an error code. That function uses a variadic argument
list to populate an error message string. However, it missed calling
va_end after using the variadic argument list.

---
NOTE: I sent a copy of this from my work email (which isn't
subscribed). Sorry if it is duplicated in the email system, but I didn't
see it land so I'm resending.

 src/gnutls.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gnutls.c b/src/gnutls.c
index 57b164a..1089b1a 100644
--- a/src/gnutls.c
+++ b/src/gnutls.c
@@ -1181,6 +1181,7 @@ boot_error (struct Lisp_Process *p, const char *m, ...)
     pset_status (p, list2 (Qfailed, vformat_string (m, ap)));
   else
     verror (m, ap);
+  va_end(ap);
 }
 
 Lisp_Object
-- 
2.5.5

Re: [PATCH] Call va_end after processing ap

[Eli Zaretskii]

> From: Aaron Conole <aconole@bytheb.org>
> Date: Mon, 02 May 2016 15:39:26 -0400
> 
> NOTE: I sent a copy of this from my work email (which isn't
> subscribed). Sorry if it is duplicated in the email system

Yes, it's duplicate.

> but I didn't see it land so I'm resending.

Please in the future be patient and allow some time for it to land:
moderators are humans that aren't constantly monitoring the list
administrative interface.