From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: libnettle/libhogweed WIP Date: Mon, 17 Apr 2017 16:50:48 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87r30qu5av.fsf@lifelogs.com> References: <83a89gq3us.fsf@gnu.org> <87bmtjiv0w.fsf_-_@lifelogs.com> <83o9xjn06c.fsf@gnu.org> <87shmeb5ln.fsf_-_@lifelogs.com> <83y3w5z1ez.fsf@gnu.org> <87lgr6yakj.fsf@lifelogs.com> <87wpamww9k.fsf@lifelogs.com> <8337daggnj.fsf@gnu.org> <87d1cdwxt6.fsf@lifelogs.com> <83tw5pg1q3.fsf@gnu.org> <87zifhulc2.fsf@lifelogs.com> <83h91og80k.fsf@gnu.org> <87pogbuhoe.fsf@lifelogs.com> <834lxndmd9.fsf@gnu.org> <87efwrug6z.fsf@lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492462305 8295 195.159.176.226 (17 Apr 2017 20:51:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 20:51:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 22:51:37 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0DcX-0001xV-10 for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 22:51:37 +0200 Original-Received: from localhost ([::1]:38713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0Dcc-0006SP-KY for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 16:51:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0Dbz-0006SH-UP for emacs-devel@gnu.org; Mon, 17 Apr 2017 16:51:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0Dbv-000549-7r for emacs-devel@gnu.org; Mon, 17 Apr 2017 16:51:04 -0400 Original-Received: from [195.159.176.226] (port=36678 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d0Dbv-00053c-1K for emacs-devel@gnu.org; Mon, 17 Apr 2017 16:50:59 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d0Dbm-0000wD-0s for emacs-devel@gnu.org; Mon, 17 Apr 2017 22:50:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 29 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:I9vtoE2vyyyAXUnR/G4WC2Fq0ds= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214093 Archived-At: On Mon, 17 Apr 2017 12:55:32 -0400 Ted Zlatanov wrote: TZ> I see the confusion. Yes, I want to allow multibyte input. Users TZ> shouldn't have to jump through hoops to use these functions. OK, the code has been changed as follows: * since I was in fns.c, I added `secure-hash-algorithms' so we know what algorithms are supported by `secure-hash'. At least for tests it's nice to have this. * factored out extract_data_from_object() from secure_hash() which incidentally defines a data format for data extraction (BUFFER-OR-STRING INPUT-START INPUT-END CODING-SYSTEM NOERROR) because I really didn't want my functions to take 20+ parameters. * secure_hash() could also take that format but I left it alone for now. * migrated secure_hash() and all the new gnutls.c crypto code to use extract_data_from_object() * added tests to verify that buffer extraction (whole buffer) works * IV, AUTH, and KEY parameters are still wiped if they were strings originally. phew... Ted