From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers, final testing Date: Wed, 12 Jul 2017 14:03:15 -0600 Message-ID: <87r2xla0e4.fsf@lylat> References: <83y3s9pm2a.fsf@gnu.org> <87eftzju5g.fsf@lylat> <837ezqq3gd.fsf@gnu.org> <874luuyuqy.fsf@lylat> <83wp7po86m.fsf@gnu.org> <87fuecc7vg.fsf@lylat> <83y3s2n5pa.fsf@gnu.org> <878tk1rmjx.fsf@lylat> <83a84gn4z9.fsf@gnu.org> <837ezkmwfg.fsf@gnu.org> <874lumps82.fsf@lylat> <8337a5ja4p.fsf@gnu.org> <83van0i5wl.fsf@gnu.org> <87iniy7ksy.fsf@lylat> <83pod6idqp.fsf@gnu.org> <87zical61u.fsf@lylat> <83mv89ivms.fsf@gnu.org> <87zic9a7tg.fsf@lylat> <8360exijpe.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499889827 26264 195.159.176.226 (12 Jul 2017 20:03:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Jul 2017 20:03:47 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: cloos@jhcloos.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 12 22:03:35 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVNrC-0006Ck-Tm for ged-emacs-devel@m.gmane.org; Wed, 12 Jul 2017 22:03:35 +0200 Original-Received: from localhost ([::1]:55715 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVNrI-0000tv-1q for ged-emacs-devel@m.gmane.org; Wed, 12 Jul 2017 16:03:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVNr4-0000tZ-Kc for emacs-devel@gnu.org; Wed, 12 Jul 2017 16:03:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVNr0-0000To-5K for emacs-devel@gnu.org; Wed, 12 Jul 2017 16:03:26 -0400 Original-Received: from mail-it0-x244.google.com ([2607:f8b0:4001:c0b::244]:34596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVNr0-0000TM-00; Wed, 12 Jul 2017 16:03:22 -0400 Original-Received: by mail-it0-x244.google.com with SMTP id o202so3653944itc.1; Wed, 12 Jul 2017 13:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=H1DA5Kl9xbnnJDG56zkaYzH8lSHCvJBVgzgzjQdPTE0=; b=n9FB9F6d7trpsZCxTXAbOofp4miE4JCkkPb6mFMpkq1bHS/QpMInE3lgCtYKtQSR51 FxAtXFFgrQEGiZG2tFj89tOv7EPQokgK6dKOau9+ynx02s+q0/Mp92B80Zu3238VYdX1 vKE9gVaYwpwrAje7307B93uVG9gl1EkbZDUN21WgHMAh5VX+0oSipf+MASj6Aq1BL/u6 7Jyn5spSGATfB0k565C2TVofCc7XUa2IpdKASGmCIP0zk0wirwkXTieRSU5qdHl2rV0N US+DRv/hBzWxTHliVchjscrFHS2n3eAJxmSG3hGK93/btSzf8J2DFgwPb4yhdJLxs08H GetQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=H1DA5Kl9xbnnJDG56zkaYzH8lSHCvJBVgzgzjQdPTE0=; b=Dtj/ejJ1kbeQbwC/vpAeJq64I/P4fZfxu/gMcv+ZPH4eJ2JQSux9OmyRt2xaKoUH9i TMQFVAb9aAhZFX8v/8eTKmjEUnoDC3+k2GVitEjcRpTD0qK9d9VEwxrPJqhviykYCtWz 7hgaE2g+M4kxbjOxwpvJLsmHMfXKccZbUlrJ4iPD4N/W52yUKZy8kIknCSaTwT11gg45 dsk1AfqTOLyA4jRw7Bzc/6cUjUr6JLTB48bUGV8ujlbgjoC5Jdd3el7PQxXiu/ukmH02 4NEux4hlnUCeKrJ8upV4uUmh31kVsIUISrUlWs96q+9ySBZyKB/NYogcTBdyDu785XAB sBTA== X-Gm-Message-State: AIVw1133gDGaBCSK+giwSMLrTRP1KMWKUQLQ/FQHq9BkbxC1jqOctBrH uQqbR2smqDc4L1RL X-Received: by 10.36.19.197 with SMTP id 188mr22306102itz.127.1499889800690; Wed, 12 Jul 2017 13:03:20 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id j12sm1955818iod.12.2017.07.12.13.03.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jul 2017 13:03:19 -0700 (PDT) In-Reply-To: <8360exijpe.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Jul 2017 21:38:53 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c0b::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216559 Archived-At: Eli Zaretskii writes: >> From: Alex >> Cc: cloos@jhcloos.com, emacs-devel@gnu.org >> Date: Wed, 12 Jul 2017 11:22:51 -0600 >> >> > It should be sensible, I agree. But "sensible" doesn't necessarily >> > mean identical to the default face's font. >> >> Sure, but I maintain in this case that it does mean identical to the >> default face's font. > > I don't understand why, and I don't think I agree. I don't see a single reason to make it different. linum didn't, and I don't know of a single editor/IDE that uses a different font than the default for the line numbers. >> It ensures, usually, proper size and a non-clashing style. > > No one said these are necessarily our goals. Not everything shown on > the initial frame uses the same font, so why should line numbers be > required to? I'd like to ask the converse: why shouldn't line numbers be in the same style/size, by default, as long as it's fixed-with? It should only deviate from the default if there's a good reason to, and I don't see a good reason to throw in serifs if the default usually/always doesn't have them. >> If someone customizes their default face, then they could customize >> the line-number face similarly. > > That's harsh on users, and exactly the reason why I made this change. > It might be a mistake, but I'd like to hear more opinions before I > make up my mind. I don't see how defaulting to serifs is less harsh. Wasn't the point of this change to stop variable-pitch-mode from affecting line numbers? In this case, using :family "Monospace" works just as well. >> Everyone else shouldn't have to do any customization. > > They (and you) don't need to. I only mentioned customization because > you didn't like the default. Good defaults are supposed to be good > for many users, but they aren't required to satisfy everyone, as long > as things are customizable. I agree with the last sentence, but I don't think this is good for many users. If it happens that most other users' systems default to a monospaced serif font, then I'll concede. Looking at face-font-family-alternatives, however, leads to me to believe that this is not the case. >> > How are fixed-pitch* different from any other face that doesn't >> > inherit from default? >> >> Going into this discussion, I figured that fixed-pitch* would be exactly >> like default, except enforcing, well, fixed-pitch; similarly for >> variable-pitch. > > But that's obviously not the intent, as the code shows and the > comments explain. I don't see any explanation around the definitions for fixed-pitch*. >> (insert (propertize "hello there!" 'face 'fixed-pitch)) >> >> This text increases along with the default face with "C-x +". Why does >> the same not apply to the line-number face? > > I don't know. Feel free to investigate and publish the findings. Well, it definitely seems like a bug to me. text-scale-mode uses face-remap-add-relative on 'default, but I don't see why this would cause an issue. The manual states that any 'unspecified attributes mean that the attributes are taken from the default face, so I don't see why adding :inherit 'default should even make a difference. Perhaps I should file a bug report?