From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: Question about test failure on Hydra Date: Tue, 01 Aug 2017 11:57:38 +0200 Message-ID: <87r2wv7gq5.fsf@rosalinde> References: <87efsxexf5.fsf@rosalinde> <83r2wx29w9.fsf@gnu.org> <8760e9eksb.fsf@rosalinde> <83ini91e2o.fsf@gnu.org> <87tw1t7yk5.fsf@rosalinde> <87efsvkijt.fsf@calancha-pc> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501581527 31887 195.159.176.226 (1 Aug 2017 09:58:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2017 09:58:47 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 01 11:58:41 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcTwl-0007vs-H5 for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 11:58:39 +0200 Original-Received: from localhost ([::1]:41472 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcTwr-0002vJ-Kd for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 05:58:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcTvu-0002sg-IW for emacs-devel@gnu.org; Tue, 01 Aug 2017 05:57:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcTvt-0001cL-N7 for emacs-devel@gnu.org; Tue, 01 Aug 2017 05:57:46 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:61992) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcTvq-0001Xv-1C; Tue, 01 Aug 2017 05:57:42 -0400 Original-Received: from rosalinde ([83.135.19.53]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MMkgl-1dl0NZ31HL-008e3W; Tue, 01 Aug 2017 11:57:38 +0200 In-Reply-To: <87efsvkijt.fsf@calancha-pc> (Tino Calancha's message of "Tue, 01 Aug 2017 13:39:50 +0900") X-Provags-ID: V03:K0:9hfTtiJrcn4Qv3KlO21izDGc1AURRkXerxnozQ6M2aEzJhJx2lm MtI8EF8DjBiW5Fpd6VEs8zfuobOzDHqrf3xqKvnZDku2ClJQUNdi993goM7y1KOFnUlUMRA 5BDr8OlsGgwS+FllI8XCcGC5LIaSP+XCnngESVFIKVPbHfdylJtRZHUm2evsMNGI1RK9QW5 iMzh/GjoE5PCJoF8/JODA== X-UI-Out-Filterresults: notjunk:1;V01:K0:SAAbqjq5D5Q=:TYlzEvdDjbOkqWCZc/t+/D zcXQoPNOWmyKk0z3GvrscZlGUxSy9aaZPRQQlkqycQJbOkuSbCDMN9oOSQJ02oUgibsM4+T9V sz/cVzZ7ZMlpotbW6newdBmDhPSV9nmIEtMgB1vA/kEiqwh0Qc+cF8p1qBb/KkhJqJLbytQaS AwV1nNbYWjoK1El6Ag611UeYA6ye7jQBDCjEqpBKW4JfmJKKY+IOGxxEr3iiDvLHDPshAPfSR kNFWc9E94WfbrOwJ/RjLY9EeAPgyFAA1+o5HjmxmbFsHy1+kkfdCcOw8JeA7oChH+YmQa7nHi 7HxdH7MgfX3cKS3s/jL5yuENUjTqmZP4gwYoQD9wEdrcbvO3ZeFjdjoivGRVwuDvoWQ3/yfGC q/feDwOy554QionwPh2S4Y1/H0NVVn9I2fnHWWDXfk01T/tvLsqrf7Ayn3AJzlfNh+ioF3HGS oWAPmZEEATTU6rJyMQUARj8e5Ea5SiWVqM/vYhRY+JMwLp9m3OCnKy5F76YBl4Fsoi4BAlzfV gUWSuFjS13svbFBSZkGRE63Jlayv+rRXX8/PbmVK+/332KFmReBIfKhgIt0UY0DGV3B72uTTO 4y7hQeKOV0KoqXmArTcAVxPFaWZp34o5q9TA1l0QzXGjYuNxefnu3nsAzZts5X23RCstu+baD 75v78SYh9Rs/mEo2wT52Hfb8J/1du4ZCqvWUQ37wmTK+Zlo6Qs3FmhnLQuzVGh84zR2DIn5HW nfpvSpqYC5vcyOWha5DulMZ/yU0lT6Gg255i0wgz5GLIUsZI/OM9pr4wGLhIiWg8I2kYSvMo X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217196 Archived-At: On Tue, 01 Aug 2017 13:39:50 +0900 Tino Calancha wrote: > Stephen Berman writes: > >> On Mon, 31 Jul 2017 06:26:55 +0300 Eli Zaretskii wrote: >> >> (dired test-dir) reverts an existing Dired buffer, because of setting >> dired-auto-revert-buffer to t. (When I step through the code, it is >> after reverting that point moves to the subdirectory line, which the >> should make "sanity check" true (and does, both when I step through the >> code and just run the test in any way). When I comment out the >> dired-auto-revert-buffer line, then point stays at point-min, which >> makes the sanity check fail (dired-file-name-at-point returns nil), > When i comment out i see the point in point-max, and the test fails > same as you but: (dired-file-name-at-point returns nil) I'm seeing point at point-max now, too, but I did see it at point-min yesterday and also when I first tried again after reading your mail, though, strangely, I can't reproduce that now. I was testing with two frames and switched back and forth between them, maybe that affects point. >> though not in the way Hydra reports (it shows point being on the ".." >> entry).) > If somehow, we have in such Dired buffer the point at ".." _before_ > call `dired-revert', then _after_ revert the point is preserved: Yes, but the question is, how does point get there in Hydra? > We can insert additional `should' calls in the failing tests and > wait until next hydra failoure. > > (Following just add more should forms into `dired-test-bug27243-01'; we > might do the same in `dired-test-bug27243-02' and `dired-test-bug27243-03'). That's probably a good idea; can you add them? (AFAIK dired-test-bug27243-03 hasn't failed in Hydra, though I can't access the logs right now to check more recent builds, but I guess it's fine to add more sanity checks. As for replacing switch-to-buffer by pop-to-buffer-same-window, I used the former in an attempt to mimic typing `C-x b', which the recipes in the bug reports use, but since it's not being called interactively, it's probably not a valid attempt anyway.) Steve Berman