From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master bb591f139f: Enhance CC Mode's fontification, etc., of unterminated strings. Date: Wed, 23 May 2018 19:21:53 -0400 Message-ID: <87r2m29cvi.fsf@md5i.com> References: <20180522174054.GA4504@ACM> <877envijii.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1527117606 1658 195.159.176.226 (23 May 2018 23:20:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 23 May 2018 23:20:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 24 01:20:02 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLd32-0000IE-W8 for ged-emacs-devel@m.gmane.org; Thu, 24 May 2018 01:20:01 +0200 Original-Received: from localhost ([::1]:35829 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLd5A-0001yN-05 for ged-emacs-devel@m.gmane.org; Wed, 23 May 2018 19:22:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLd4x-0001x9-Kq for emacs-devel@gnu.org; Wed, 23 May 2018 19:22:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLd4s-0003BL-MF for emacs-devel@gnu.org; Wed, 23 May 2018 19:21:59 -0400 Original-Received: from md5i.com ([75.151.244.229]:42550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fLd4s-0003Ay-GX for emacs-devel@gnu.org; Wed, 23 May 2018 19:21:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=74J2OCMU4Ja1Npi++qYej+UZgl23rqKrf5PyRjPAdXg=; b=Whli9IE//zNFx00jzxtnmNedwh hp2AOLD9cbMAs32Srkdq0WDMTc+h9rQV1IhMqtszmukSguDgBBAj6Qzp3XZxwMyvCQwQtE9+LOEaV ZCRmvC3HfqZQ/oDcsTMrK2IiU; Original-Received: from md5i by md5i.com with local (Exim 4.91) (envelope-from ) id 1fLd4r-0004zB-QZ for emacs-devel@gnu.org; Wed, 23 May 2018 19:21:53 -0400 In-Reply-To: <877envijii.fsf@gmail.com> (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora?= =?iso-8859-1?Q?=22's?= message of "Tue, 22 May 2018 20:21:25 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 75.151.244.229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225637 Archived-At: joaotavora@gmail.com (Jo=E3o T=E1vora) writes: > PS: you could also have used: > > M-x ert-describe-test RET electric-pair-autowrapping-5-at-point-2-in-c= ++-mode-in-strings > > Which would have rendered a nice docstring > > electric-pair-autowrapping-5-at-point-2-in-c++-mode-in-strings is a > test defined in `electric-tests.elc'. >=20=20=20=20=20=20 > With |"foo"|, try input " at point 2. Should become |""foo""| and poi= nt at 3 >=20=20=20=20=20=20 > [back] > > Though, admittedly, this is misleading for the "autowrapping" tests, > since it doesn't tell you about the "mark-sexp" region-making > command. Also not immediatly clear perhaps it that the | are buffer > boundaries. > > Ideally, it should read read > > With |"foo"|, at point 2, (mark-sexp 1) and try input ". > Should become |""foo""| and point at 3 > > I will try to fix this in master. > > Also M-x ert-find-test-other-window could have helped you, but it > doesn't (brings me to the beginning of the file, which isn't helpful). I > don't know why, does anyone? Could the macros that generate the ert-deftest call not set `definition-name' in the generated function's symbol property list that leads back to `define-electric-pair-test`'s name element? That might help `find-function-search-for-symbol' find the correct location. --=20 Michael Welsh Duggan (md5i@md5i.com)