From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7b31de4: Add hook for all events Date: Mon, 28 Jan 2019 09:42:14 +0000 Message-ID: <87r2cxunih.fsf@russet.org.uk> References: <20190122214637.25164.20429@vcs0.savannah.gnu.org> <20190122214639.B2E13203DD@vcs0.savannah.gnu.org> <40f2dac5-f342-b9f0-a792-796a6baf9a56@dancol.org> <87fttj55t8.fsf@russet.org.uk> <87k1iu2v8x.fsf@russet.org.uk> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="143033"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 28 10:43:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go3Rf-000b6S-04 for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 10:43:11 +0100 Original-Received: from localhost ([127.0.0.1]:56729 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go3Rd-0003dF-QC for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 04:43:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go3RX-0003cu-Ck for emacs-devel@gnu.org; Mon, 28 Jan 2019 04:43:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1go3RV-0000aY-Ts for emacs-devel@gnu.org; Mon, 28 Jan 2019 04:43:03 -0500 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:43270) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1go3RV-0000Jz-5F for emacs-devel@gnu.org; Mon, 28 Jan 2019 04:43:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QUtL0jAT3ESPV+nClGJOjm4XBbyEHunj/VcZX4t0Qcs=; b=a4/FrCZDUPFk4OGC3r1Sh6lef 8JTWCZIwjdL/1hwQXuaUA6j1s6HS7xiNrPtUKc4geJlZQ2AhPdiBhlCc+KaM1Kg1QlG3aVqHGGuFF RwoDElHmqhhY25a6yXybxFIdeW6zQW+4nJKe4j1sKaO8Xb1rG3Dgu0XguvzqIr2Lr2gZmMqSRoTSV u6lWOC+t62UNjuXyvXUP85tsAaficc22cCHBti5C2LwzZ06ZHkN1cZjP5F1fpSokAEUmimLAW6zvr OIC2/SKCu//6OUbnNcR3D/mz2e8UjqLyCoj6ouLXeN2zzjzzwV6NpzPVr3E4w7h+ZdP4wOIHdu4BZ cjwGwHyTA==; Original-Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:45228 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1go3Ql-003wme-1I; Mon, 28 Jan 2019 09:42:15 +0000 In-Reply-To: (Stefan Monnier's message of "Fri, 25 Jan 2019 08:56:35 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 78.129.138.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232755 Archived-At: Stefan Monnier writes: >> Well, you should find it better; this hook is your code (I stole it from >> a patch you sent in 2015). Sit-for, yes, would be a possibility, that I >> hadn't thought off; you'd still need to filter the event using >> `last-input-event' I guess. That would be a way of fixing company and >> pabbrev in current Emacs. I will investigate. > > Another way might be to use a before/after-change-function (i.e. don't > detect an input event but rather detect that the input method inserted > something into the buffer). I haven't checked, but I always assumed that input methods do not insert anything in the buffer until a key sequence completes; rather than everything was visual. Perhaps not; pabbrev used to insert suggestions into the buffer, until you fixed it. Phil