From: Alex Gramiak <agrambot@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: alan@idiocy.org, emacs-devel@gnu.org
Subject: Re: [PATCH] Renaming non-X x_* identifiers
Date: Mon, 15 Apr 2019 11:46:18 -0600 [thread overview]
Message-ID: <87r2a3jh5h.fsf@gmail.com> (raw)
In-Reply-To: <83h8azianr.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 Apr 2019 17:51:52 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Alex Gramiak <agrambot@gmail.com>
>> Cc: emacs-devel@gnu.org, alan@idiocy.org
>> Date: Sun, 14 Apr 2019 11:34:22 -0600
>>
>> The calls should already be #ifdef'd; it's the declarations that would
>> be #ifdef'd.
>>
>> > I thought those which don't need to be tested are available on both
>> > GUI and TTY frames.
>>
>> I believe there are (currently) three categories:
>>
>> (a) Hooks implemented by all backends, which don't need to be tested.
>>
>> (b) Hooks implemented by only GUI frames, but occurring in branches that
>> non-GUI frames are used. These have to be tested.
>>
>> (c) Hooks implemented by only GUI frames, and occurring in branches that
>> only GUI frames are used, and are in a preprocessor conditional. These
>> don't have to be (and some currently aren't) tested.
>
> Thanks, now the issue is clear.
>
> I think I'd prefer to treat (c) the same as (b), though, i.e. add the
> tests where we don't have them, and leave the declarations visible in
> all builds. My reasoning is that the current situation is more or
> less ad-hoc, and therefore some of the (c) could at some point become
> (b). If and when that happens, treating them the same will allow
> easier rearrangement of the code. By contrast, having such a modified
> code fail to compile would require the person making the change to
> perform some non-trivial analysis of why that hook was not declared,
> then move its declaration out of the #ifdef.
That makes sense. I pushed the relevant changes. Is it okay that I left
the get_focus_frame hook in do_switch_frame (frame.c) unchecked? It's
enclosed by a FRAME_WINDOW_P, so a comment in termhooks.c mandating that
window systems implement that hook should be sufficient, no? On the
other hand, it's the only one remaining in the generic code that's left
unchecked.
> It would also increase the number of #ifdef's, which I think is both
> uglier
Indeed.
> and farther from the goal of supporting several window-systems in the
> same session.
Not sure about this, as long the hooks' calling sites and declarations
are compiled in for each supported window-system. I think it would be
different if using #ifndefs, though.
Are there any other issues to discuss, besides the comments in
termhooks.h (which I'll work on soon)? Have you tested this branch on
w32 to check if I missed anything there?
next prev parent reply other threads:[~2019-04-15 17:46 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 15:07 Renaming non-X x_* procedures in xdisp.c (and elsewhere) Alex
2019-03-23 15:38 ` Stefan Monnier
2019-03-23 16:10 ` Eli Zaretskii
2019-03-23 16:41 ` Paul Eggert
2019-03-23 16:59 ` Eli Zaretskii
2019-03-23 17:39 ` Alex
2019-03-23 17:54 ` Alex
2019-03-23 18:16 ` Eli Zaretskii
2019-03-23 18:55 ` Alex
2019-03-23 19:32 ` Eli Zaretskii
2019-03-24 4:14 ` Alex
2019-03-24 4:50 ` Alex
2019-03-24 5:39 ` Eli Zaretskii
2019-03-24 15:05 ` Alex
2019-03-24 16:01 ` Yuri Khan
2019-03-24 16:13 ` Eli Zaretskii
2019-03-24 17:03 ` Eli Zaretskii
2019-03-24 16:27 ` Eli Zaretskii
2019-03-24 18:30 ` Alex
2019-03-24 18:48 ` Eli Zaretskii
2019-03-25 19:21 ` Alex
2019-03-30 10:07 ` Eli Zaretskii
2019-03-30 17:26 ` Alex
2019-03-30 17:40 ` Eli Zaretskii
2019-03-30 17:59 ` Alex
2019-03-30 18:55 ` Eli Zaretskii
2019-03-30 23:27 ` Alex
2019-03-31 14:52 ` Eli Zaretskii
2019-04-11 19:07 ` Alex
2019-04-12 19:03 ` Eli Zaretskii
2019-04-12 19:50 ` Alex Gramiak
2019-04-12 20:10 ` Eli Zaretskii
2019-04-13 16:26 ` Alex Gramiak
2019-04-13 17:20 ` Eli Zaretskii
2019-04-13 16:13 ` [PATCH] Renaming non-X x_* identifiers (was: Renaming non-X x_* procedures in xdisp.c (and elsewhere)) Alex Gramiak
2019-04-13 17:17 ` Eli Zaretskii
2019-04-13 18:43 ` [PATCH] Renaming non-X x_* identifiers Alex Gramiak
2019-04-13 19:00 ` Eli Zaretskii
2019-04-14 3:35 ` Alex Gramiak
2019-04-14 14:02 ` Eli Zaretskii
2019-04-14 15:57 ` Alex Gramiak
2019-04-14 16:10 ` Eli Zaretskii
2019-04-14 17:34 ` Alex Gramiak
2019-04-15 14:51 ` Eli Zaretskii
2019-04-15 17:46 ` Alex Gramiak [this message]
2019-04-15 18:43 ` Eli Zaretskii
2019-04-16 16:24 ` Alex Gramiak
2019-04-16 16:45 ` Eli Zaretskii
2019-04-16 16:59 ` Alex Gramiak
2019-04-16 17:04 ` Eli Zaretskii
2019-04-16 17:07 ` Alex Gramiak
2019-04-16 18:09 ` Eli Zaretskii
2019-04-24 19:40 ` Alex Gramiak
2019-04-25 5:25 ` Eli Zaretskii
2019-04-25 9:56 ` Eli Zaretskii
2019-04-25 14:50 ` Alex Gramiak
2019-04-25 15:04 ` Eli Zaretskii
2019-04-26 6:52 ` Robert Pluim
2019-04-26 8:07 ` Eli Zaretskii
2019-04-26 23:12 ` Alex Gramiak
2019-04-15 22:01 ` Stefan Monnier
2019-04-16 2:29 ` Eli Zaretskii
2019-04-16 12:55 ` Stefan Monnier
2019-04-16 14:58 ` Eli Zaretskii
2019-04-14 3:47 ` Stefan Monnier
2019-04-27 1:53 ` Basil L. Contovounesios
2019-04-27 3:46 ` Alex Gramiak
2019-04-27 11:37 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2a3jh5h.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).