unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: Gnus nnir patch for Emacs 26?
Date: Fri, 14 Jun 2019 01:18:39 -0700	[thread overview]
Message-ID: <87r27weg0w.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 83v9x8ya89.fsf@gnu.org

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Date: Thu, 13 Jun 2019 15:20:52 -0700
>> 
>> > If this patch indeed fixes the problem, it's okay for emacs-26, but
>> > please only add that one line, don't reindent anything and don't
>> > replace lambda with its fancier equivalent.  Just the minimal required
>> > change.
>> 
>> Here's a proper commit with a simpler-looking version that doesn't
>> re-indent everything. I've done before-and-after tests and this works
>> just the same. I've also added a do not merge thing following Robert's
>> pointer.
>> 
>> How's it look?
>
> Fine with me, thanks.

Cool, will push tomorrow.

> P.S. I was wondering why we use all those wrappers around
> decode-coding-string instead of calling the latter directly, but since
> you are saying this code will go away in Emacs 27, this is a moot
> point.  I do suggest to look for such trivial wrappers on master and
> eliminate them if any are still there, as a cleanup.

The code in scratch/gnus-decoded will do some of that, since the point
of that branch is to make sure group names are decoded strings as they
enter the system, rather than decoding them as they come out of the
system (ie, as they are presented to the user).




      reply	other threads:[~2019-06-14  8:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 21:46 Gnus nnir patch for Emacs 26? Eric Abrahamsen
2019-06-13  7:02 ` Robert Pluim
2019-06-13 10:04 ` Eli Zaretskii
2019-06-13 22:20   ` Eric Abrahamsen
2019-06-14  6:03     ` Eli Zaretskii
2019-06-14  8:18       ` Eric Abrahamsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r27weg0w.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).