unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
       [not found] ` <20190818224935.1ACDA20A0E@vcs0.savannah.gnu.org>
@ 2019-08-18 22:51   ` Lars Ingebrigtsen
  2019-08-19  2:37     ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2019-08-18 22:51 UTC (permalink / raw)
  To: emacs-devel; +Cc: Johan Claesson

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit b82adee1f64231236d50b48662d3419417ba5d48
> Author: Johan Claesson <johanclaesson@bredband.net>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Invalidate dir-locals-directory-cache when writing dir-local file
>
>     * lisp/files-x.el (modify-dir-local-variable): Remove file from
>     the cache when writing to ensure that we load the new version
>     later (bug#13860).

Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
late to amend after I've pushed?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
  2019-08-18 22:51   ` master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file Lars Ingebrigtsen
@ 2019-08-19  2:37     ` Eli Zaretskii
  2019-08-19  9:32       ` Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2019-08-19  2:37 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: johanclaesson, emacs-devel

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 18 Aug 2019 15:51:56 -0700
> Cc: Johan Claesson <johanclaesson@bredband.net>
> 
> >     Invalidate dir-locals-directory-cache when writing dir-local file
> >
> >     * lisp/files-x.el (modify-dir-local-variable): Remove file from
> >     the cache when writing to ensure that we load the new version
> >     later (bug#13860).
> 
> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
> late to amend after I've pushed?

Too late.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
  2019-08-19  2:37     ` Eli Zaretskii
@ 2019-08-19  9:32       ` Stefan Monnier
  2019-08-19  9:52         ` Štěpán Němec
  2019-08-19 14:46         ` Eli Zaretskii
  0 siblings, 2 replies; 9+ messages in thread
From: Stefan Monnier @ 2019-08-19  9:32 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Lars Ingebrigtsen, emacs-devel, johanclaesson

>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
>> late to amend after I've pushed?
> Too late.

Yup.  Hard to believe we're still stuck with this problem of "unfixable
commit messages" after all these years.


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
  2019-08-19  9:32       ` Stefan Monnier
@ 2019-08-19  9:52         ` Štěpán Němec
  2019-08-19 17:05           ` Noam Postavsky
  2019-08-19 14:46         ` Eli Zaretskii
  1 sibling, 1 reply; 9+ messages in thread
From: Štěpán Němec @ 2019-08-19  9:52 UTC (permalink / raw)
  To: Stefan Monnier
  Cc: Eli Zaretskii, johanclaesson, Lars Ingebrigtsen, emacs-devel

On Mon, 19 Aug 2019 05:32:20 -0400
Stefan Monnier wrote:

>>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
>>> late to amend after I've pushed?
>> Too late.
>
> Yup.  Hard to believe we're still stuck with this problem of "unfixable
> commit messages" after all these years.

There's "git notes", but I guess you're aware of that.

<https://git-scm.com/docs/git-notes>: "A typical use of notes is to
supplement a commit message without changing the commit itself."

-- 
Štěpán



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
  2019-08-19  9:32       ` Stefan Monnier
  2019-08-19  9:52         ` Štěpán Němec
@ 2019-08-19 14:46         ` Eli Zaretskii
  2019-08-19 16:45           ` Ergus via Emacs development discussions.
  1 sibling, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2019-08-19 14:46 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: larsi, emacs-devel, johanclaesson

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  johanclaesson@bredband.net,  emacs-devel@gnu.org
> Date: Mon, 19 Aug 2019 05:32:20 -0400
> 
> >> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
> >> late to amend after I've pushed?
> > Too late.
> 
> Yup.  Hard to believe we're still stuck with this problem of "unfixable
> commit messages" after all these years.

We can solve it easily if we go back to CVS.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
  2019-08-19 14:46         ` Eli Zaretskii
@ 2019-08-19 16:45           ` Ergus via Emacs development discussions.
  2019-08-19 17:25             ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Ergus via Emacs development discussions. @ 2019-08-19 16:45 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: larsi, johanclaesson, Stefan Monnier, emacs-devel

On Mon, Aug 19, 2019 at 05:46:47PM +0300, Eli Zaretskii wrote:
>> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  johanclaesson@bredband.net,  emacs-devel@gnu.org
>> Date: Mon, 19 Aug 2019 05:32:20 -0400
>>
>> >> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
>> >> late to amend after I've pushed?
>> > Too late.
>>
>> Yup.  Hard to believe we're still stuck with this problem of "unfixable
>> commit messages" after all these years.
>
>We can solve it easily if we go back to CVS.
>
This can be fixed with a rebase or a note.

But

A rebase in a public repo is not recommended, so that's why the
fork-join workflow is usually more extended (and the default in gitlab,
github and bitbucked). So the user pushes, rebases and fixes in it's
fork freely as in a local branch, with the advantage that other users
can pull/test and comment the changes (code, message, number of commits,
benchmarks, tests) before they go in the main repo. And only few users
have write access to the master repo and they decide how to add the
changes with a rebase, a merge or a rebase+merge with no-ff (to have
linear or grouped history...).




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
  2019-08-19  9:52         ` Štěpán Němec
@ 2019-08-19 17:05           ` Noam Postavsky
  2019-08-20  7:48             ` Štěpán Němec
  0 siblings, 1 reply; 9+ messages in thread
From: Noam Postavsky @ 2019-08-19 17:05 UTC (permalink / raw)
  To: Štěpán Němec
  Cc: Lars Ingebrigtsen, Eli Zaretskii, Emacs developers,
	Stefan Monnier, Johan Claesson

On Mon, 19 Aug 2019 at 05:52, Štěpán Němec <stepnem@gmail.com> wrote:

> >>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
> >>> late to amend after I've pushed?
> >> Too late.
> >
> > Yup.  Hard to believe we're still stuck with this problem of "unfixable
> > commit messages" after all these years.
>
> There's "git notes", but I guess you're aware of that.
>
> <https://git-scm.com/docs/git-notes>: "A typical use of notes is to
> supplement a commit message without changing the commit itself."

Although this only adds to the message, right? A few years ago,
someone proposed 'git replace --edit' for this, but I found it creates
a lot of refs which cause noticeable slowdown for all git
operations[1]. Not sure if 'git notes' would also create many refs.
Andreas Schwab mentioned something about a new git refs backend to
scale better[2]. Did anything ever come of that?

[1]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01240.html
[2]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01185.html



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
  2019-08-19 16:45           ` Ergus via Emacs development discussions.
@ 2019-08-19 17:25             ` Eli Zaretskii
  0 siblings, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2019-08-19 17:25 UTC (permalink / raw)
  To: Ergus; +Cc: larsi, emacs-devel, monnier, johanclaesson

> Date: Mon, 19 Aug 2019 18:45:04 +0200
> Cc: larsi@gnus.org, johanclaesson@bredband.net,
>  Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
> From: Ergus via "Emacs development discussions." <emacs-devel@gnu.org>
> 
> This can be fixed with a rebase or a note.

Savannah disallows such rebases, and rightfully so.  In extreme
situations (and this is not one of them) we can ask the Savannah
admins to do that manually.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
  2019-08-19 17:05           ` Noam Postavsky
@ 2019-08-20  7:48             ` Štěpán Němec
  0 siblings, 0 replies; 9+ messages in thread
From: Štěpán Němec @ 2019-08-20  7:48 UTC (permalink / raw)
  To: Noam Postavsky
  Cc: Lars Ingebrigtsen, Johan Claesson, Eli Zaretskii, Stefan Monnier,
	Emacs developers

On Mon, 19 Aug 2019 13:05:58 -0400
Noam Postavsky wrote:

> On Mon, 19 Aug 2019 at 05:52, Štěpán Němec <stepnem@gmail.com> wrote:
>
>> >>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
>> >>> late to amend after I've pushed?
>> >> Too late.
>> >
>> > Yup.  Hard to believe we're still stuck with this problem of "unfixable
>> > commit messages" after all these years.
>>
>> There's "git notes", but I guess you're aware of that.
>>
>> <https://git-scm.com/docs/git-notes>: "A typical use of notes is to
>> supplement a commit message without changing the commit itself."
>
> Although this only adds to the message, right? A few years ago,
> someone proposed 'git replace --edit' for this, but I found it creates
> a lot of refs which cause noticeable slowdown for all git
> operations[1]. Not sure if 'git notes' would also create many refs.
> Andreas Schwab mentioned something about a new git refs backend to
> scale better[2]. Did anything ever come of that?
>
> [1]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01240.html
> [2]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01185.html

Ah, I knew the git notes suggestion seemed too obvious to be useful...
It seems good for adding a pseudo-header to an occasional commit after
the fact (without changing the commit object) such as here, but I'd
expect you hit the same scalability issues as demonstrated in your tests
with git replace, if used in bulk on a repo of this size. (I have no
data to back that up, though, neither can I comment on your second
question.)

-- 
Štěpán



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-08-20  7:48 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20190818224934.1914.38804@vcs0.savannah.gnu.org>
     [not found] ` <20190818224935.1ACDA20A0E@vcs0.savannah.gnu.org>
2019-08-18 22:51   ` master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file Lars Ingebrigtsen
2019-08-19  2:37     ` Eli Zaretskii
2019-08-19  9:32       ` Stefan Monnier
2019-08-19  9:52         ` Štěpán Němec
2019-08-19 17:05           ` Noam Postavsky
2019-08-20  7:48             ` Štěpán Němec
2019-08-19 14:46         ` Eli Zaretskii
2019-08-19 16:45           ` Ergus via Emacs development discussions.
2019-08-19 17:25             ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).