unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Štěpán Němec" <stepnem@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
	Johan Claesson <johanclaesson@bredband.net>,
	Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file
Date: Tue, 20 Aug 2019 09:48:26 +0200	[thread overview]
Message-ID: <87r25g1dmd.fsf@gmail.com> (raw)
In-Reply-To: <CAM-tV--y7QUc4X+CcAb4RNXAyER_1zAWsebK=pjzGqM0_vVxUw@mail.gmail.com> (Noam Postavsky's message of "Mon, 19 Aug 2019 13:05:58 -0400")

On Mon, 19 Aug 2019 13:05:58 -0400
Noam Postavsky wrote:

> On Mon, 19 Aug 2019 at 05:52, Štěpán Němec <stepnem@gmail.com> wrote:
>
>> >>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
>> >>> late to amend after I've pushed?
>> >> Too late.
>> >
>> > Yup.  Hard to believe we're still stuck with this problem of "unfixable
>> > commit messages" after all these years.
>>
>> There's "git notes", but I guess you're aware of that.
>>
>> <https://git-scm.com/docs/git-notes>: "A typical use of notes is to
>> supplement a commit message without changing the commit itself."
>
> Although this only adds to the message, right? A few years ago,
> someone proposed 'git replace --edit' for this, but I found it creates
> a lot of refs which cause noticeable slowdown for all git
> operations[1]. Not sure if 'git notes' would also create many refs.
> Andreas Schwab mentioned something about a new git refs backend to
> scale better[2]. Did anything ever come of that?
>
> [1]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01240.html
> [2]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01185.html

Ah, I knew the git notes suggestion seemed too obvious to be useful...
It seems good for adding a pseudo-header to an occasional commit after
the fact (without changing the commit object) such as here, but I'd
expect you hit the same scalability issues as demonstrated in your tests
with git replace, if used in bulk on a repo of this size. (I have no
data to back that up, though, neither can I comment on your second
question.)

-- 
Štěpán



  reply	other threads:[~2019-08-20  7:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190818224934.1914.38804@vcs0.savannah.gnu.org>
     [not found] ` <20190818224935.1ACDA20A0E@vcs0.savannah.gnu.org>
2019-08-18 22:51   ` master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file Lars Ingebrigtsen
2019-08-19  2:37     ` Eli Zaretskii
2019-08-19  9:32       ` Stefan Monnier
2019-08-19  9:52         ` Štěpán Němec
2019-08-19 17:05           ` Noam Postavsky
2019-08-20  7:48             ` Štěpán Němec [this message]
2019-08-19 14:46         ` Eli Zaretskii
2019-08-19 16:45           ` Ergus via Emacs development discussions.
2019-08-19 17:25             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r25g1dmd.fsf@gmail.com \
    --to=stepnem@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=johanclaesson@bredband.net \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).