unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>,
	emacs-devel@gnu.org, Juri Linkov <juri@linkov.net>
Subject: Re: Image-conversion shims
Date: Wed, 09 Oct 2019 21:26:04 +0200	[thread overview]
Message-ID: <87r23l67qr.fsf@gnus.org> (raw)
In-Reply-To: <jwvv9szxhej.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 08 Oct 2019 13:47:58 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I still can't see why we should care about our ability to display an
> image before preferring image-mode over fundamental-mode.

It just feels odd to be mapping file extensions to a mode when we don't
know whether that mode can display the file meaningfully or not.  We
don't do that with other file types, so why with images?

But in practice I guess it doesn't make much difference.  It's more of a
cleanliness thing.

> IOW, I think the auto-mode-alist entries should be added statically not
> based on what we can do with them, but based on what the extension means
> in practice.
>
> Typically, there are various cases:
> - things like .svg and .xpm which can be meaningfully viewed as "an
>   image" or as "a text file".  There, we should make sure the user can
>   switch between those two views (and default to text if we can't
>   display the image, e.g. via image-mode-maybe).
> - extensions which are sometimes used for images and sometimes for
>   completely unrelated purposes.  We should decide based on
>   which is most likely to the case.

Since we don't default to using the external converters for exotic image
formats, when the user has switched it on, that's a signal that the user
does want those to be mapped to images, perhaps, which is a practical
argument for having the mappings be dynamic.

> - extensions which are always images and can't meaningfully be edited
>   within Emacs, so only image-mode makes sense.

In that case we should change image-mode to not display stuff like this
for formats it doesn't understand:

Type C-c C-c or C-c C-x to view the image as an image or hex.
Cannot display image: (Cannot determine image type)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2019-10-09 19:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28 20:06 Image-conversion shims Lars Ingebrigtsen
2019-09-28 20:37 ` Clément Pit-Claudel
2019-09-28 21:20   ` Lars Ingebrigtsen
2019-09-29  6:24   ` Eli Zaretskii
2019-09-28 21:05 ` Stefan Monnier
2019-09-28 21:21   ` Lars Ingebrigtsen
2019-09-28 23:29   ` Lars Ingebrigtsen
2019-09-29  0:01     ` Lars Ingebrigtsen
2019-09-29  7:11     ` Eli Zaretskii
2019-09-29 11:44       ` Lars Ingebrigtsen
2019-09-29 11:56         ` Eli Zaretskii
2019-09-30  4:12           ` Lars Ingebrigtsen
2019-09-30  7:06             ` Eli Zaretskii
2019-09-30 13:42               ` Lars Ingebrigtsen
2019-09-30 14:01                 ` Eli Zaretskii
2019-10-01 12:06                   ` Lars Ingebrigtsen
2019-10-01 12:36                     ` Eli Zaretskii
2019-09-30 17:27             ` Stefan Monnier
2019-10-01 12:08               ` Lars Ingebrigtsen
2019-10-01 13:09                 ` Stefan Monnier
2019-10-06 20:58             ` Juri Linkov
2019-10-07  1:41               ` Lars Ingebrigtsen
2019-10-07 18:48                 ` Juri Linkov
2019-10-08 16:06                   ` Lars Ingebrigtsen
2019-10-08 17:47                     ` Stefan Monnier
2019-10-09 19:26                       ` Lars Ingebrigtsen [this message]
2019-10-09 19:53                         ` Stefan Monnier
2019-10-14  4:53                           ` Lars Ingebrigtsen
2019-10-14 19:27                             ` Juri Linkov
2019-10-14 19:41                               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r23l67qr.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).