From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: 31395511: =?utf-8?Q?=22Don=E2=80=99t?= attempt to modify constant strings" Date: Thu, 04 Jun 2020 10:31:21 +0100 Message-ID: <87r1uvkwie.fsf@gmail.com> References: <871rmvn7ge.fsf@gmail.com> <87lfl36abx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="83482"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Paul Eggert , emacs-devel To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 04 11:32:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgmEF-000Lcf-Hm for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 11:32:03 +0200 Original-Received: from localhost ([::1]:34090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgmEE-0005HQ-Kn for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 05:32:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgmDf-0004kP-1M for emacs-devel@gnu.org; Thu, 04 Jun 2020 05:31:27 -0400 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:33001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgmDd-0000yJ-WE for emacs-devel@gnu.org; Thu, 04 Jun 2020 05:31:26 -0400 Original-Received: by mail-wm1-x331.google.com with SMTP id j198so6411765wmj.0 for ; Thu, 04 Jun 2020 02:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=4GsxEQnYIsXHRwyhuY9V5ZAZsH5Baoh6p139jn17KWs=; b=eTi4G0ML0eR/VSeMhLR5OmcQTKskWBYK6YdPcusbtHL0FXw6ahF9NnyUmAjgaPlvoe PmQJHwgFg8IQ3HlJwZmNk5JFIwncCBQZvif0UU2JFsBRnOFfK6NkHedW0orKKXeNRfKt wt4bb19F5f10oHtgdwwCwkKyR9uJowdDJe2yVK1me2WMBPLafHk7I6iwijUZUvLx6Bgj 8Ph3FnVyO29J1BNA5xm0kxSzatv8AEKXOT8M4N3yEpkz9HpI9605kGQwjXsFwHuLi0OB Z+DLFN1NQmEKedA0WB6WdLHAc4A8NQgeaWcVIoC+zxsnZ3HrfVR2r57hnhLPgYICen++ Hyeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=4GsxEQnYIsXHRwyhuY9V5ZAZsH5Baoh6p139jn17KWs=; b=LE9MBsRjqaQMUsLcsjpAsUjZ2p8qWr537S9KG0uzfHV6X3juMVVEJulQtWEu4rfKRO OWGFFDR9FpY+F62DpkqbEox1CNZyTkF2i6WYSATRmVpCJiJnC6ElmJqxG9UT5l5LuJxk N/OuYRTALk9lJRgAtIcYGV9rHE+ZaJqp/J9fFfus68d13Zv4dCh6kelpMnz85sY/Q3ZC duS2UaCc1wOZBTh8w0Jh9MywJD5EQt6XhrImNTLQaZRaXyiGGWo87Fyii5m3S7y5oR50 eDN0uDMrcfJtiVrnh3o2bfDV/QfS4ImOeqYQg3LStiPIes21Y4VTdaFSpTtHV4xkUkGg w0lg== X-Gm-Message-State: AOAM531wbE849nglr6YdHtfiVjpvkSNBWKTuCOwAA/sxDvHcHgfphgF9 LlOCVLoDQNQrjIHJ4QIJDOQ= X-Google-Smtp-Source: ABdhPJw8NjFbRZka7GCpfrOlSk3GcB4qpTcSjw8so4xwJD7lNFF47OIjh61GiRd6l0XfNOxOIkq8Tw== X-Received: by 2002:a7b:c7d8:: with SMTP id z24mr3052364wmk.28.1591263084370; Thu, 04 Jun 2020 02:31:24 -0700 (PDT) Original-Received: from krug ([89.180.148.153]) by smtp.gmail.com with ESMTPSA id y37sm8507907wrd.55.2020.06.04.02.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2020 02:31:23 -0700 (PDT) In-Reply-To: (Pip Cet's message of "Thu, 4 Jun 2020 04:38:19 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x331.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251847 Archived-At: Pip Cet writes: > On Wed, Jun 3, 2020 at 11:48 PM Jo=C3=A3o T=C3=A1vora wrote: >> On Wed, Jun 3, 2020 at 11:42 PM Pip Cet wrote: >> By itself, that doesn't work. I have the same problem. > > Strange, I'd tried it locally and it appeared to work. Yep, I didn't dig in, but it seems now that some buttons works and other's don't work. So in a REPL typing "123" CL-USER> 123 123 (7 bits, #x7b, #o173, #b1111011) doesn't work (the second line should be interactive and it's not). But now I did dig in and that's because other code is using the same paradigm that sly-make-action-button was using. Everything should work if I track such users and change them. I think I will lose compatibility to ~24.4, which is where I developed this code. Oh well. >> I think I'd rather this previous behavior were retained, or at least >> achievable by request. I haven't touched this code in a long >> I don't know what else might depend on it. > > But the previous behavior was buggy. Things like > > (defun sly-inspector-insert-more-button (index previous) > (insert (sly-make-action-button > (if previous " [--more--]\n" " [--more--]") > #'sly-inspector-fetch-more > 'range-args (list index previous)))) > > worked only by accident, before. =20=20 Accident/spec/divine providence: they worked, and for a long time. make-text-button never warned me about mutability/immutability, constant strings or non-constant strings. So effectively we're changing the sepc implicit or explicit, in a backwards-incompatible way, and that breaks programs, case in point. Jo=C3=A3o PS: I admit I didn't check the recent "incompatible lisp changes" NEWS for recent Emacs versions, maybe there's something in there that could have given me a heads up.