From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 80abaea: Use lexical-binding in lunar.el and add tests Date: Sun, 07 Jun 2020 23:10:13 +0100 Message-ID: <87r1uqo7cq.fsf@tcd.ie> References: <20200607190128.16579.5580@vcs0.savannah.gnu.org> <20200607190130.38C4E20A2E@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="73014"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 08 00:11:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ji3Vj-000IuC-EA for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jun 2020 00:11:23 +0200 Original-Received: from localhost ([::1]:38782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ji3Vi-0003DQ-G8 for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Jun 2020 18:11:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ji3Ug-0002hv-WF for emacs-devel@gnu.org; Sun, 07 Jun 2020 18:10:19 -0400 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:45044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ji3Uf-0006ex-EU for emacs-devel@gnu.org; Sun, 07 Jun 2020 18:10:18 -0400 Original-Received: by mail-wr1-x433.google.com with SMTP id y17so15360862wrn.11 for ; Sun, 07 Jun 2020 15:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RO506G10Q4fQntt3OKtP0AzRnpN798oSt4Gsh1Fmlbs=; b=OxxgIJ7htnfkKKFNJ4wgPPHJkkRGmtVUrHuJSfEczWI6E13fsJGhu6SZ6GiWZ73ak1 qTcphrvRaQWoHKUJYE9b1utsLxSL64/MxDRsAeaynWUyKlT7AbsX+bCf+UYsgZqRn6tx 8OnqChkZ9u3RJgrLPXAfqQxj12Zj5BHDPDpFYOzgtVrHR4hAkPBVuimcAP6itGUrw0wZ pJjFIZYmhcE2W1QMhhfcMdD6Ba8b6d3FlwIxxXoSzfW9VYm5a/kg6fofSyEbVt+jTNUn rokkvH7JtMDTp+IJ2HP5rqKHKer5gyT4/3pd41Jg5OxtOITX/5ceK7YvaFuNOKGy1MIq bvJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RO506G10Q4fQntt3OKtP0AzRnpN798oSt4Gsh1Fmlbs=; b=gYcyakvn6lmm7VNgrpqSsDP/FZH/vUzECbjgebShP3hwaph6pHvz2bYLmUugiTOtPx pqZWF+UvcAi2ezHcQddoSjnMft6ryUCheLr9edWnAONhLnRNQytTiCH2NCCgIA8v1y4W N/XH3VAq3valSIr171gz8kV3I+fyR7bfQ/+Us98hvGpmsLGmBOBL1DyFEQR+mrbkzejT r805Sg3b6rjBg4w5H66t1ygJq0Trt3KnS1jHexD2GSZZaciAxW3ijQOZrkJ8sBsd/zLC VnlIGV4VjYtwcsB7gJ1lsjXzKG/H7snX9AmuXl9oUBACOuLqWxNW0YV2+iI3towuTWFZ 6AEA== X-Gm-Message-State: AOAM5313MoCcngKwj60q74TDeAeega93IpE5cJzh1ZZh11RVBY/lSUF+ ZvTBLwD86l4twd1co7y17idFcq8n0yOXiw== X-Google-Smtp-Source: ABdhPJxP8u6+gTyAGCV7icZcozECE/CdS2Zwvj1fy7WAhPGAe2jbK4A6v4sUSQ7+G53rAJT3Fn0RDw== X-Received: by 2002:a5d:554b:: with SMTP id g11mr20545728wrw.260.1591567814852; Sun, 07 Jun 2020 15:10:14 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id p1sm20732258wrx.44.2020.06.07.15.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2020 15:10:14 -0700 (PDT) In-Reply-To: <20200607190130.38C4E20A2E@vcs0.savannah.gnu.org> (Stefan Kangas's message of "Sun, 7 Jun 2020 15:01:29 -0400 (EDT)") Received-SPF: none client-ip=2a00:1450:4864:20::433; envelope-from=contovob@tcd.ie; helo=mail-wr1-x433.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252028 Archived-At: stefankangas@gmail.com (Stefan Kangas) writes: > branch: master > commit 80abaea1d9c6f1e53fe88befe16de3b219cdd919 > Author: Stefan Kangas > Commit: Stefan Kangas > > Use lexical-binding in lunar.el and add tests > > * lisp/calendar/lunar.el: Use lexical-binding. > (lunar-phases, diary-lunar-phases): Silence byte-compiler. > * test/lisp/calendar/lunar-tests.el: New file. I'm seeing the following test failure: --8<---------------cut here---------------start------------->8--- cd test; make lunar-tests make[1]: Entering directory '/home/blc/.local/src/emacs/test' GEN lisp/calendar/lunar-tests.log Running 5 tests (2020-06-07 23:05:51+0100, selector `(not (tag :unstable))') passed 1/5 lunar-test-eclipse-check (0.000202 sec) passed 2/5 lunar-test-new-moon-on-or-after (0.002254 sec) passed 3/5 lunar-test-new-moon-time (0.000106 sec) passed 4/5 lunar-test-phase (0.000145 sec) Test lunar-test-phase-list backtrace: signal(ert-test-failed (((should (equal (lunar-phase-list 3 1871) '( ert-fail(((should (equal (lunar-phase-list 3 1871) '(((3 20 1871) "1 (if (unwind-protect (setq value-12 (apply fn-10 args-11)) (setq form (let (form-description-14) (if (unwind-protect (setq value-12 (apply (let ((value-12 'ert-form-evaluation-aborted-13)) (let (form-descrip (let* ((fn-10 #'equal) (args-11 (condition-case err (let ((signal-ho (let ((calendar-latitude 40.1) (calendar-longitude -88.2) (calendar- (closure (t) nil (let ((calendar-latitude 40.1) (calendar-longitude ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name lunar-test-phase-list :documentation ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/calendar/lunar-tests command-line() normal-top-level() Test lunar-test-phase-list condition: (ert-test-failed ((should (equal (lunar-phase-list 3 1871) '...)) :form (equal ((... "9:03pm" 0 "") (... "11:46pm" 1 "** Eclipse **") (... "7:20am" 2 "") (... "10:57pm" 3 "** Eclipse possible **") (... "12:06pm" 0 "") (... "4:49pm" 1 "") (... "3:57pm" 2 "") (... "7:29am" 3 "") (... "3:46am" 0 "") (... "6:02am" 1 "")) ((... "11:03pm" 0 "") (... "1:46am" 1 "** Eclipse **") (... "9:20am" 2 "") (... "12:57am" 3 "** Eclipse possible **") (... "2:06pm" 0 "") (... "6:49pm" 1 "") (... "5:57pm" 2 "") (... "9:29am" 3 "") (... "5:46am" 0 "") (... "8:02am" 1 ""))) :value nil :explanation (list-elt 0 (list-elt 1 (arrays-of-different-length 6 7 "9:03pm" "11:03pm" first-mismatch-at 0))))) FAILED 5/5 lunar-test-phase-list (0.000611 sec) Ran 5 tests, 4 results as expected, 1 unexpected (2020-06-07 23:05:51+0100, 0.173134 sec) 1 unexpected results: FAILED lunar-test-phase-list --8<---------------cut here---------------end--------------->8--- In case it matters, my time zone is (format-time-string "%Z %z") ; => "IST +0100" Any ideas? Thanks, -- Basil