From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: RFC: Automatic setup for bug-reference-mode Date: Thu, 18 Jun 2020 15:37:59 +0200 Message-ID: <87r1ucwl3c.fsf@gnu.org> References: <87r1uihtsu.fsf@gnu.org> <87h7vd3cbs.fsf@gnu.org> <87tuzdsj8d.fsf@gnu.org> <87tuzd755z.fsf@gnu.org> <86o8pkabzh.fsf@stephe-leake.org> <87pna0mxxw.fsf@gnu.org> <87ftatcr48.fsf@mail.linkov.net> <87mu50c3gy.fsf@gnu.org> <59a15059-2ba5-5fcb-c6aa-3c9877394e1d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="50336"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel , Stephen Leake , Juri Linkov To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 18 15:46:20 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlus0-000D08-24 for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jun 2020 15:46:20 +0200 Original-Received: from localhost ([::1]:40708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlury-0007HY-Rw for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jun 2020 09:46:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jluk9-0002AJ-SG for emacs-devel@gnu.org; Thu, 18 Jun 2020 09:38:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40406) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jluk8-0000Ss-3O; Thu, 18 Jun 2020 09:38:12 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:36787) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jluk1-0005WY-Vy; Thu, 18 Jun 2020 09:38:08 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 6C19427C0054; Thu, 18 Jun 2020 09:38:05 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 18 Jun 2020 09:38:05 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejgedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe dvueefkeeuleekheffffdtieduvdfhffdtgfekhfejueejudehudekveefvedvhfenucfk phepleefrddvfeeirddufeehrdeljeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgr lhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgse hfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: from thinkpad-t440p (p5dec8761.dip0.t-ipconnect.de [93.236.135.97]) by mail.messagingengine.com (Postfix) with ESMTPA id CB6EE328005A; Thu, 18 Jun 2020 09:38:02 -0400 (EDT) Mail-Followup-To: Dmitry Gutov , Juri Linkov , Stephen Leake , emacs-devel In-Reply-To: <59a15059-2ba5-5fcb-c6aa-3c9877394e1d@yandex.ru> (Dmitry Gutov's message of "Thu, 18 Jun 2020 12:46:40 +0300") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252311 Archived-At: Dmitry Gutov writes: > On 18.06.2020 09:06, Tassilo Horn wrote: >> I think the actual problem was that >> git config branch..remote >> wasn't necessarily called in the given project DIR so returned the >> global default remote "origin". > > I... don't think so? > > It returned an empty string in my testing. Which resulted in > remote-url being nil. I've tested and written my fix with a version before your change (and wrongly using M-: (vc-git-dir-extra-headers "repo/no/origin/remote")). And there I got the remote "origin" (which doesn't exist in that repo). Oh, I think that's because I did the M-: while being in vc-git.el, so it looked at the emacs repo, not the one in the DIR argument! Well, if you got the remote "", I still think that default-directory was set to some non-git repo directory at that time. At least =E2=9D=AF git config branch.master.remote returns successfully but empty in such a directory. It's not exactly clear to me when vc-dir sets default-directory. So if you want to find out, you could checkout an emacs version before our changes and invoke vc-dir from somewhere where default-directory is not in some git repo. I think you'd get that error no matter if the DIR of vc-dir has a remote origin or not. Bye, Tassilo