Re: [PATCH] Add user option to disable location in bookmarks

[Jamie Beardslee <beardsleejamie@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

>> My patch allows the user to choose whether or not the bookmark record
>> should be in control of the position.
>
> The bookmark record has already chosen that.  Just use a different
> kind of record.  Why have an option that acts in a blanket manner on
> all bookmarks, to ignore their position?

I don't see the problem here, surely some users would want to ignore
bookmarks' positions.  There isn't a similar built-in library that
doesn't save position so I feel it should be an option provided by
bookmark.el without the user needing to define their own handler.

> If this is about save-place then save-place should do the right thing.
> See above.  If there's an option to be added in that regard, it's a
> save-place option: `save-place-ignore-bookmark-position'.  The hook
> function (see above) can move to the save-place place if the option is
> non-nil, and just do nothing if it's nil.

Okay, well I've attached that patch here.  I understand this is skipping
over one of the best features of bookmarks, but I still think it's a
valuable option even without the use of save-place.

--
Jamie


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Allow-save-place-to-override-the-position-when-using.patch --]
[-- Type: text/x-patch, Size: 1797 bytes --]

From c4378882ef88fafcd04017d1942f673658b04dd1 Mon Sep 17 00:00:00 2001
From: Jamie Beardslee <beardsleejamie@gmail.com>
Date: Sun, 21 Jun 2020 11:59:44 +1200
Subject: [PATCH] Allow save-place to override the position when using
 bookmarks.

When the user option `save-place-override-bookmark' is non-nil,
save-place will go to the last position rather than the position
specified in the bookmark record.
---
 lisp/saveplace.el | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/lisp/saveplace.el b/lisp/saveplace.el
index 46738ab03d..f32c1ad753 100644
--- a/lisp/saveplace.el
+++ b/lisp/saveplace.el
@@ -118,12 +118,22 @@ save-place-ignore-files-regexp
   :version "24.1"
   :type 'regexp)
 
+(defcustom save-place-override-bookmark nil
+  "Whether `save-place' should override bookmarks.
+
+Normally, a bookmark is used to save a specific point in a buffer
+or file.  If this is non-nil, `save-place' will provide the
+position instead."
+  :type 'boolean)
+
 (declare-function dired-current-directory "dired" (&optional localp))
 
 (defun save-place--setup-hooks (add)
   (cond
    (add
     (add-hook 'find-file-hook #'save-place-find-file-hook t)
+    (eval-after-load "bookmark"
+      '(add-hook 'bookmark-after-jump-hook #'save-place-bookmark-hook t))
     (add-hook 'dired-initial-position-hook #'save-place-dired-hook)
     (unless noninteractive
       (add-hook 'kill-emacs-hook #'save-place-kill-emacs-hook))
@@ -334,6 +344,10 @@ save-place-find-file-hook
           ;; and make sure it will be saved again for later
           (setq save-place-mode t)))))
 
+(defun save-place-bookmark-hook ()
+  (when save-place-override-bookmark
+    (save-place-find-file-hook)))
+
 (declare-function dired-goto-file "dired" (file))
 
 (defun save-place-dired-hook ()
-- 
2.27.0