From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Wed, 24 Feb 2021 19:09:55 +0000 Message-ID: <87r1l5cmf0.fsf@tcd.ie> References: <87h7m5iagw.fsf@gnus.org> <87r1l5efba.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27616"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 24 20:24:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEzm4-00074n-Aa for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Feb 2021 20:24:40 +0100 Original-Received: from localhost ([::1]:54784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEzm3-0005eQ-BK for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Feb 2021 14:24:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEzY1-0002k3-Hc for emacs-devel@gnu.org; Wed, 24 Feb 2021 14:10:13 -0500 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:41991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEzXu-0007r8-CQ for emacs-devel@gnu.org; Wed, 24 Feb 2021 14:10:08 -0500 Original-Received: by mail-wr1-x42e.google.com with SMTP id r3so2927817wro.9 for ; Wed, 24 Feb 2021 11:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WxQNlNwaNrXzEpt4xADf/v8jPuMgK/S+muogOX1J508=; b=IvqrZWyB6Qf/5yrUHK0Ut220tPZRLwfjWJq5Om32CqB7KhwRVa6g4Lu97l4MjFIreC hTba1IyV7i4GOAY0+BKfoUt3E7KyNkos4Hww9/U+gVSK0gvDw0v+/7X0gr4QkEPaSQan hB1MCDKK2a9QLnZJ/zczxvfdWEm+b3ACXlSImV+a5TYjT0kIpzFHht6ZmWc8gYMli/Pk Amz7k7lNpW7xglSLU2eDdxRoNSsKd3f/ihNVhHRm3nKN8V6/w9/rSrwe2ZJIuBaC9WWr txc7g+PFRcaq2EzYFzL1l5YvG6LZAaeiKFohS5ZN1ZVNidSRQPp4HHCd2aShbI6tspPI RmZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WxQNlNwaNrXzEpt4xADf/v8jPuMgK/S+muogOX1J508=; b=lV+/CyYzFwTN3b7FiLuWySCZls1KibfmwHLkTejGB/GEtYOYJoJo7YwMNkhhEpthNU gfg3LuB2MxWFcvfcbif3vwY+F1KuaZnwkoBbyNLw7UNz63WWjkKwfV9jaGfIjrMEZ4gm mDeYfKbJjUktfGyGa8C1xu5jRDHft1anXjth9n2LqYj6Z/i9zIzt8UErIlJixzQPSmO0 ghwgc+b0Y4vHO4wPZWm3eUfhwMzjjA9YmWMDXuIp+1KWyEpYrTD2nj8p90/gSTRRXnC8 5XfQL7bZhlF4doP2ro0pxhN8ohCYi37BjmHbJL/sJEMcfaFnT/vd9X0SsHaQDFtvRIEa xaNg== X-Gm-Message-State: AOAM533Suyf/PdO/YMQ/UjOm9wDtJornWAaVmBazq05Zsa6PVIKkAElM AigiQ8IzE44yWNRdBG4pB2XOVQ== X-Google-Smtp-Source: ABdhPJx1oHUurRrtf8alC1acvqFMvGwRUM2MZfzLBM/l+9wXdXcQje1ASBT+Dkrep8sIbUWicu/a3A== X-Received: by 2002:a5d:6503:: with SMTP id x3mr16819016wru.249.1614193797359; Wed, 24 Feb 2021 11:09:57 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id t11sm3998736wmb.32.2021.02.24.11.09.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 11:09:56 -0800 (PST) In-Reply-To: (Stefan Kangas's message of "Wed, 24 Feb 2021 10:35:47 -0600") Received-SPF: none client-ip=2a00:1450:4864:20::42e; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265589 Archived-At: Stefan Kangas writes: > "Basil L. Contovounesios" writes: >> >>> + (replace-match (propertize >>> + (key-description >>> + (substring (this-command-keys) 0 -1)) >>> + 'font-lock-face 'help-key-binding >>> + 'face 'help-key-binding) >> >> Why not use help--key-description-fontified here? > > Using it would introduce a circular dependency between help-macro.el and > help.el. How would it do that given that neither make-help-screen nor the defun it expands to is used within help-macro.el? -- Basil