From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Adam_Sj=C3=B8gren?= Newsgroups: gmane.emacs.devel Subject: Re: long-standing GTK bug Date: Sun, 09 May 2021 17:11:58 +0200 Organization: koldfront - analysis & revolution, Copenhagen, Denmark Message-ID: <87r1igx7pd.fsf@tullinup.koldfront.dk> References: <83zhbcg6s4.fsf@gnu.org> <87r1wng2ki.fsf@linaro.org> <83o8rrenn1.fsf@gnu.org> <87blnr6uck.fsf@tullinup.koldfront.dk> <87wo5kumkn.fsf_-_@tullinup.koldfront.dk> <86ftc5hc8j.fsf@gmail.com> <87d079io10.fsf@tullinup.koldfront.dk> <87ftbyokll.fsf@tullinup.koldfront.dk> <83a71c71id.fsf@gnu.org> <83sgf356sy.fsf@gnu.org> <87o8dl8mv1.fsf@tullinup.koldfront.dk> <87fsyw42yg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16857"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:bGHVxF59G0NhNeiY6TfAROU8kgc= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 09 17:14:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfl8Z-0004Hz-3J for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 17:14:31 +0200 Original-Received: from localhost ([::1]:46708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfl8Y-0002Yj-5g for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 11:14:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfl6v-0008Fq-2g for emacs-devel@gnu.org; Sun, 09 May 2021 11:12:49 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:52124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfl6F-0002vv-U7 for emacs-devel@gnu.org; Sun, 09 May 2021 11:12:48 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lfl6D-0001QP-6k for emacs-devel@gnu.org; Sun, 09 May 2021 17:12:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ OpenPGP: id=476630590A231909B0A0961A49D0746121BDE416; url=https://asjo.koldfront.dk/gpg.asc X-Face: )qY&CseJ?.:=8F#^~GcSA?F=9eu'{KAFfL1C3/A&:nE?PW\i65"ba0NS)97, Q(^@xk}n4Ou rPuR#V8I(J_@~H($[ym:`K_+]*kjvW>xH5jbgLBVFGXY:(#4P>zVBklLbdL&XxL\M)%T}3S/IS9lMJ ^St'=VZBR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269081 Archived-At: Robert writes: > Interesting, but ENOPATCH :-) I don't know what the preferred way to go about this is, but here is one: Skip "keep terminal open"-workaround for pure GTK --- src/frame.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/frame.c b/src/frame.c index eb5aed82f7..8fdef3941d 100644 --- a/src/frame.c +++ b/src/frame.c @@ -2183,7 +2183,7 @@ delete_frame (Lisp_Object frame, Lisp_Object force) /* If needed, delete the terminal that this frame was on. (This must be done after the frame is killed.) */ terminal->reference_count--; -#if defined (USE_X_TOOLKIT) || defined (USE_GTK) +#if defined (USE_X_TOOLKIT) || defined (USE_GTK) && ! defined (HAVE_PGTK) /* FIXME: Deleting the terminal crashes emacs because of a GTK bug. https://lists.gnu.org/r/emacs-devel/2011-10/msg00363.html */ @@ -2194,7 +2194,7 @@ delete_frame (Lisp_Object frame, Lisp_Object force) if (terminal->reference_count == 0 && (terminal->type == output_x_window || terminal->type == output_pgtk)) terminal->reference_count = 1; -#endif /* USE_X_TOOLKIT || USE_GTK */ +#endif /* USE_X_TOOLKIT || USE_GTK && ! HAVE_PGTK */ if (terminal->reference_count == 0) { Lisp_Object tmp; > (thereʼs a separate test that needs doing using waypipe rather than > ssh X forwarding. I think that one causes an abort somewhere inside > GTK) (I haven't tried Wayland yet, so I have no information on that.) Best regards, Adam -- "Someone said ``look, it's Milli Vanilli!'' but Adam Sjøgren that's totally unfair to Milli Vanilli: at least asjo@koldfront.dk they danced."