From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Mon, 24 May 2021 23:37:07 +0100 Message-ID: <87r1hviwrw.fsf@gmail.com> References: <87zgwlb4xc.fsf@gmail.com> <87eedxrqz4.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38586"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Daniel Mendler , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 00:37:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llJCn-0009ok-Qr for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 00:37:49 +0200 Original-Received: from localhost ([::1]:52584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llJCm-0004Nz-Tl for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 18:37:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llJCE-0003cr-Kl for emacs-devel@gnu.org; Mon, 24 May 2021 18:37:14 -0400 Original-Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:38602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llJCC-0002bt-Q8 for emacs-devel@gnu.org; Mon, 24 May 2021 18:37:14 -0400 Original-Received: by mail-wm1-x329.google.com with SMTP id u4-20020a05600c00c4b02901774b80945cso12241798wmm.3 for ; Mon, 24 May 2021 15:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Dh65CAIn7B8sdsDGkaoV+4oBwj2pliD7tLANBCbNLtI=; b=GrEsYWo1HqhQi1fIvTifUezLrmXH4N15cow/T7l929Qo0Mb5pX0T+ooYRJUDLkD+ta VgxP7COasdrGQsd6xGaxZ74AasZvUdPMb6x2GxfOjzNHzB5O3TA6oWP+Wt64WTAnZlJv vnydnDJNoAw6ei6dFpJwaIzD9JH96KtWaisDGblszdftyk9Zwvc5OLPzfdPo8L03aMYN Db8xUV5yvUxtA+DHI8/NragsYZ2c339hSSoCJG0ZzEYWJolExe4Euo0N4PRLtD/3dlLf +Vo2foeWU85hRWihRIwarvo2W1wwDFeiL09XdHhx0XEgPx6tgIZ6BUV4AxebRAUehtar qwrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Dh65CAIn7B8sdsDGkaoV+4oBwj2pliD7tLANBCbNLtI=; b=aBh9j9MIJ/B9RSMxapAx3h/1RASEPgdNpr/c/QatySjeOIC4zgt5biDBBDEjxCtKUs lCd67OBs0Xv9civFPz1ZmapuFxCVCM+/ZxyF5M9cV4QPWuBXG9ORf2rntXSzzsxVDyjK qISr6CH65tl42+c3EdfwJG065uMH0ySYyTcdtf5W7tEa0CGvTYxcgD9NV09OCi6wzuig yKVOvuI4pgb0YKR6yROOXOl9WezXYvYgFU8qiqcp7UtNmdiAT2ZB8pECNKB3lUG0u6QJ IrG9CkoaY2AqSLrlC+ELid96ECd4mAtst6n+ZMqlijChVEp6IOYBcaGbHmLnGDDM+dV+ FFjg== X-Gm-Message-State: AOAM531gCtbPBDe7Wx342D+jfN9gDICrzAZJ3IJNX5dAWHgET7dHZ0BK JYB3p1D2CwHe0VriPL4oMuM= X-Google-Smtp-Source: ABdhPJxod51yNRyaUgo5bmXY86LSZh/D0d8zcWXhX9GSyDOfp0WrKOr9sfwv2ftr8kChaNuMpBBRYA== X-Received: by 2002:a05:600c:219:: with SMTP id 25mr975386wmi.156.1621895830295; Mon, 24 May 2021 15:37:10 -0700 (PDT) Original-Received: from krug (a94-133-55-152.cpe.netcabo.pt. [94.133.55.152]) by smtp.gmail.com with ESMTPSA id y2sm810206wmq.45.2021.05.24.15.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 15:37:09 -0700 (PDT) In-Reply-To: <87eedxrqz4.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 24 May 2021 02:35:19 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269815 Archived-At: Juri Linkov writes: >> I also don't understand why :affixation-function is given a full list of >> completions, when it is presumably meant to return a list of exactly the >> same length. > > This has the advantage in functions like read-extended-command--affixatio= n, > where minibuffer-selected-window is selected only once with with-selected= -window, > then all completions are processed in the same buffer, without the need > to switch buffers for every completion in a long list, as annotation-func= tion > would require to do.=20 I've seen this in read-extended-command--affixation.el indeed. I don't understand: - the need for this window switch, but I might be missing something; - if the need is to process in the same buffer, why one switches windows; - why it can't and shouldn't be done in the funcall locus by the frontend (in this case minibuffer-completion-help) >> Seems like a potential hazard to allow this function to do filtering. > > OTOH, not allowing the function to do filtering is too much hand-holding > for users who want the freedom to transform the completions to their > likings. But if they exercise this freedom fully they're going to break the layout of the frontend, like icomplete.el, which potentially does layout calculations. Probably company.el or any other frontend is the same. So not so much holding hands, more like saving feet from being shot :-). Jo=C3=A3o