From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Cleaning up rcirc Date: Fri, 11 Jun 2021 14:51:40 +0000 Message-ID: <87r1h8v4hv.fsf@posteo.net> References: <874kedu0cm.fsf@posteo.net> <877dj94liu.fsf@igel.home> <87im2tlcwy.fsf@posteo.net> <87sg1urfwu.fsf@gnu.org> <87sg1pwwfd.fsf@posteo.net> <87zgvx34s4.fsf@gnu.org> <87sg1pidwy.fsf@posteo.net> <87a6nx9ecz.fsf@gnu.org> <877dj0aoop.fsf@gnu.org> <87k0n0ixag.fsf@posteo.net> <874ke4agi9.fsf@gnu.org> <87im2kwx9z.fsf@posteo.net> <87wnr08xj0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23383"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 11 16:52:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lriWH-0005vN-PN for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Jun 2021 16:52:25 +0200 Original-Received: from localhost ([::1]:36090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lriWG-0004uB-Nf for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Jun 2021 10:52:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lriVc-0003Wn-5k for emacs-devel@gnu.org; Fri, 11 Jun 2021 10:51:44 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:39359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lriVa-0004TJ-Ga for emacs-devel@gnu.org; Fri, 11 Jun 2021 10:51:43 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 5133224002A for ; Fri, 11 Jun 2021 16:51:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1623423101; bh=bbg7L9ydtxoBsIuMuti7xnQnCgonzD77HpAbqzMN7cg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=oRUHy5KwcrsTzN+5vFaF9QOXoEpco2kLpYqXT0Aq0z/LV+yBFu/K5JzT9Qltzv85g CceFNu6IejAMQdovFW5Jq4nnslnA4hhYHUntkZkZEXAdl1cdwNJGVgQvJHAn1DTGcv yh+5RvXfGohKCD0KU6UhgbJqh2qekbzIeyFc9QS2iQmu583p0NxVYAnRgGEtgvmnFd xlW3t0o9E+dCHomf+eskIy4sbWvQ+WHLMxiRpODAdb24ANW5YIIEKNaRUDvQO6BiTX RKtOcPPKoTSayi12kV3n1gjcnzdkfjfkRWP8qodsMeNx4EAOb/fKTFakMGqWVgZi0r JZsTrOzkJmV1A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4G1kM10F47z9rxM; Fri, 11 Jun 2021 16:51:40 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <87wnr08xj0.fsf@gnu.org> (Tassilo Horn's message of "Fri, 11 Jun 2021 13:10:55 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270703 Archived-At: Tassilo Horn writes: > Hi Philip, > >>> No, not really. `rcirc-update-activity-string' just updates >>> `rcirc-activity-string'. Maybe that should call >>> >>> (force-mode-line-update t) >>> >>> at least if the new and old activity string aren't equal? >> >> I cannot reproduce the issue (at least in my GUI instance, I'll take a >> look at TUI). Can you observe it making a difference? > > Yes, with this patch it works for me on my TUI instance. (I'm not sure > if that's the right thing to do, though.) > > modified lisp/net/rcirc.el > @@ -2154,7 +2154,8 @@ rcirc-next-active-buffer > (concat > " Type C-u " (key-description (this-command-keys)) > " for low priority activity.") > - ""))))) > + ""))) > + (rcirc-update-activity-string))) > > (define-obsolete-variable-alias 'rcirc-activity-hooks > 'rcirc-activity-functions "24.3") > @@ -2229,7 +2230,8 @@ rcirc-update-activity-string > ((not (null (rcirc-process-list))) > "[]") > (t "[]"))) > - (run-hooks 'rcirc-update-activity-string-hook))) > + (run-hooks 'rcirc-update-activity-string-hook) > + (force-mode-line-update t))) Hmm, it is probably worth adding this then. > (defun rcirc-activity-string (buffers) > "Generate activity string for all BUFFERS." > > Bye, > Tassilo > -- Philip K.