Re: Cleaning up rcirc

[Philip Kaludercic <philipk@posteo.net>]

Tassilo Horn <tsdh@gnu.org> writes:

> Hi Philip,
>
>>> No, not really.  `rcirc-update-activity-string' just updates
>>> `rcirc-activity-string'.  Maybe that should call
>>>
>>>   (force-mode-line-update t)
>>>
>>> at least if the new and old activity string aren't equal?
>>
>> I cannot reproduce the issue (at least in my GUI instance, I'll take a
>> look at TUI). Can you observe it making a difference?
>
> Yes, with this patch it works for me on my TUI instance.  (I'm not sure
> if that's the right thing to do, though.)
>
> modified   lisp/net/rcirc.el
> @@ -2154,7 +2154,8 @@ rcirc-next-active-buffer
>                     (concat
>                      "  Type C-u " (key-description (this-command-keys))
>                      " for low priority activity.")
> -                 "")))))
> +                 "")))
> +    (rcirc-update-activity-string)))
>
>  (define-obsolete-variable-alias 'rcirc-activity-hooks
>    'rcirc-activity-functions "24.3")
> @@ -2229,7 +2230,8 @@ rcirc-update-activity-string
>                  ((not (null (rcirc-process-list)))
>                   "[]")
>                  (t "[]")))
> -    (run-hooks 'rcirc-update-activity-string-hook)))
> +    (run-hooks 'rcirc-update-activity-string-hook)
> +    (force-mode-line-update t)))

Hmm, it is probably worth adding this then.

>  (defun rcirc-activity-string (buffers)
>    "Generate activity string for all BUFFERS."
>
> Bye,
> Tassilo
>

-- 
	Philip K.