From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target Date: Wed, 29 Sep 2021 15:42:50 +0200 Message-ID: <87r1d73312.fsf@gnu.org> References: <831r58k0cx.fsf@gnu.org> <87tui4qyni.fsf@gnu.org> <83tui4iift.fsf@gnu.org> <874ka43rp1.fsf@gnu.org> <83ee97il43.fsf@gnu.org> <87zgrv33mf.fsf@gnu.org> <838rzfijnj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10645"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.0; emacs 28.0.50 Cc: rudiwillalwaysloveyou@gmail.com, stefankangas@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 29 15:51:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVZzg-0002Xo-OJ for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 15:51:32 +0200 Original-Received: from localhost ([::1]:50660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZzf-0003MO-1Q for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 09:51:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZxk-00016T-Hb for emacs-devel@gnu.org; Wed, 29 Sep 2021 09:49:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57410) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZxk-0001NM-4c; Wed, 29 Sep 2021 09:49:32 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:56579) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZxj-0006uI-Uz; Wed, 29 Sep 2021 09:49:31 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailauth.nyi.internal (Postfix) with ESMTP id 73EDF27C0064; Wed, 29 Sep 2021 09:49:31 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 29 Sep 2021 09:49:31 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepve evieekteekveeigfefffeivdetgeduvdffueeuudevgedttdehvdfhueevfffhnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 09:49:30 -0400 (EDT) In-reply-to: <838rzfijnj.fsf@gnu.org> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275796 Archived-At: Eli Zaretskii writes: >> That's already the case without this patch and emacs 27.2 started >> with "emacs -Q". I have both foo and bar directories in my dired >> buffer, then hit R on foo and complete bar/. It will move foo inside >> of bar. The very same happens if I just complete to bar without >> trailing /. > > And with the proposed change, the last sentence will no longer happen, > right? That's the change in behavior I was talking about. It still happens the very same way. The only thing this patch is concerned with is that if bar (specified as bar/) does not exist yet, it will be created as directory before doing the operation (i.e., the rename or copy). So basically we have those Rename/Copy semantics: file -> 2.txt (renames plain file no matter if 2.txt already exists) file -> foo (move into foo if that's an existing dir, otherwise rename) file -> foo/ (move into directory foo, creating if not existing and dired-create-destination-dirs is non-nil) The first 2 are unchanged, the third one is the new one. > Or am I missing something? The above. :-) And Rudi, please correct me if I'm wrong. But I think I've tested quite thoroughly. Bye, Tassilo