Re: master ad5cf84fa7: Add `auth-info-password' and use it instead of ad hoc code

Re: master ad5cf84fa7: Add `auth-info-password' and use it instead of ad hoc code

[Michael Albinus]

Sam Steingold <sds@gnu.org> writes:

Hi Sam,

>     Add `auth-info-password' and use it instead of ad hoc code

Thanks for this! Would you mind to add also a description of this
function to auth.texi, for the benefit of other package authors? As
bonus, also a test in auth-source-tests.el?

Whether this is good for an etc/NEWS entry I don't know, but likely yes.

--8<---------------cut here---------------start------------->8---
> +(defun auth-info-password (auth-info)
> +  "Return the :secret password from the AUTH-INFO."
> +  (let ((secret (plist-get auth-info :secret)))
>      (if (functionp secret)
>          (funcall secret)
>        secret)))
--8<---------------cut here---------------end--------------->8---

Tramp ought to use a different implementation:

--8<---------------cut here---------------start------------->8---
> -		 (while (functionp auth-passwd)
> -		   (setq auth-passwd (funcall auth-passwd)))
--8<---------------cut here---------------end--------------->8---

I have no reference for the problem which has triggered this, all I've
found is this ChangeLog entry:

--8<---------------cut here---------------start------------->8---
2018-05-02  Michael Albinus  <michael.albinus@gmx.de>

	* tramp.el: ...
	(tramp-read-passwd): auth-source could return cascaded functions.
--8<---------------cut here---------------end--------------->8---

Perhaps it is better to use the loop as well in auth-info-password?

Best regards, Michael.

Re: master ad5cf84fa7: Add `auth-info-password' and use it instead of ad hoc code

[Corwin Brust]

Hi Michael,

On Sat, Jan 8, 2022 at 2:54 AM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> Sam Steingold <sds@gnu.org> writes:
>
> Tramp ought to use a different implementation:
>
> --8<---------------cut here---------------start------------->8---
> > -              (while (functionp auth-passwd)
> > -                (setq auth-passwd (funcall auth-passwd)))
> --8<---------------cut here---------------end--------------->8---
>
> I have no reference for the problem which has triggered this, all I've
> found is this ChangeLog entry:
>
> --8<---------------cut here---------------start------------->8---
> 2018-05-02  Michael Albinus  <michael.albinus@gmx.de>
>
>         * tramp.el: ...
>         (tramp-read-passwd): auth-source could return cascaded functions.
> --8<---------------cut here---------------end--------------->8---
>
> Perhaps it is better to use the loop as well in auth-info-password?

Looking at this patch last night I had the same idea  -- I don't see
any reason *not* to allow cascaded functions in all cases while not
allowing this for Tramp would actually be breaking.

FWIW, I too wondered if there was any bug related to this or if this
was simply pushed as an ad-hoc improvement across core/bundled
packages.

Warm regards,
Corwin

Re: master ad5cf84fa7: Add `auth-info-password' and use it instead of ad hoc code

[Michael Albinus]

Corwin Brust <corwin@bru.st> writes:

> Hi Michael,

Hi Corwin,

> FWIW, I too wondered if there was any bug related to this or if this
> was simply pushed as an ad-hoc improvement across core/bundled
> packages.

Today, I've scanned the Tramp mail archive, but I couldn't find any
related message. Likely, this was a problem which happened through my
Tramp tests, and I've just fixed it silently.

> Warm regards,
> Corwin

Best regards, Michael.

Re: master ad5cf84fa7: Add `auth-info-password' and use it instead of ad hoc code

[Sam Steingold]

Hi Michael,

> * Michael Albinus <zvpunry.nyovahf@tzk.qr> [2022-01-08 08:58:19 +0100]:
> Sam Steingold <sds@gnu.org> writes:
>
>>     Add `auth-info-password' and use it instead of ad hoc code
>
> Thanks for this! Would you mind to add also a description of this
> function to auth.texi, for the benefit of other package authors? As
> bonus, also a test in auth-source-tests.el?

Sure, will do.

>> +(defun auth-info-password (auth-info)
>> +  "Return the :secret password from the AUTH-INFO."
>> +  (let ((secret (plist-get auth-info :secret)))
>>      (if (functionp secret)
>>          (funcall secret)
>>        secret)))
>
>
> Tramp ought to use a different implementation:
>
>> -		 (while (functionp auth-passwd)
>> -		   (setq auth-passwd (funcall auth-passwd)))
>
>
> I have no reference for the problem which has triggered this, all I've
> found is this ChangeLog entry:
>
> 2018-05-02  Michael Albinus  <michael.albinus@gmx.de>
>
> 	* tramp.el: ...
> 	(tramp-read-passwd): auth-source could return cascaded functions.
>
> Perhaps it is better to use the loop as well in auth-info-password?

Tramp is the only package that assumes "cascaded functions".
Are you sure `auth-source' _can_ return them?

Thank you.

-- 
Sam Steingold (http://sds.podval.org/) on Pop 21.10 (impish) X 11.0.12013000
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://www.memritv.org https://ij.org/ https://iris.org.il
Brainwashing leads to brain drain.