Re: [PATCH] Findirect_function

[Manuel Giraud <manuel@ledu-giraud.fr>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>    /* Optimize for no indirection.  */
>> -  if (SYMBOLP (fun) && !NILP (fun)
>> -      && (fun = XSYMBOL (fun)->u.s.function, SYMBOLP (fun)))
>> -    {
>> -      fun = indirect_function (fun);
>> -      if (NILP (fun))
>> -	/* Let funcall get the error.  */
>> -	fun = args[0];
>> -    }
>> +  fun = Findirect_function(fun, Qt);
>> +  if (NILP (fun))
>> +    /* Let funcall get the error.  */
>> +    fun = args[0];
>
> This should remove the corresponding comment.

You mean the /* Optimize… */ comment, right?

> And I think I'd only be willing to make such a change if it comes with
> some benchmarking showing that this optimization does not actually make
> a difference.

Do you happen to have some hints on how to do benchmarking in emacs? 😅
-- 
Manuel Giraud